Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xgboost version conflict #2

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Fix xgboost version conflict #2

merged 1 commit into from
Dec 28, 2022

Conversation

jdworzans
Copy link
Contributor

There is version conflict described in apache/tvm#12009
Versions restriction as in https://github.com/apache/tvm/blob/main/python/gen_requirements.py#L279,
added to Apache TVM should eliminate this conflict.

glatosinski
glatosinski requested changes Dec 25, 2022
View reviewed changes
Copy link
Member

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems ok, please amend the commit so it sounds more like:

environments: Fixed xgboost version conflict

@jdworzans
environments: Fixed xgboost version conflict
5df8413 
Signed-off-by: Jakub Dworzański <dworzanski.jakub@gmail.com>
@jdworzans
Copy link
Contributor Author

The code seems ok, please amend the commit so it sounds more like:

environments: Fixed xgboost version conflict

Ok, done

@glatosinski glatosinski self-requested a review December 28, 2022 17:38
glatosinski
glatosinski approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glatosinski
Copy link
Member

One small thing - we should wrap xgboost>=1.1.0,<1.6.0 in quotas so the parser accepts this - I will apply it in the master branch.

@glatosinski glatosinski merged commit 945285f into antmicro:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glatosinski glatosinski glatosinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdworzans @glatosinski