Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(derive): Stage Log Targets #310

Merged
merged 1 commit into from
Jun 25, 2024
Merged

chore(derive): Stage Log Targets #310

merged 1 commit into from
Jun 25, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 24, 2024 •
edited
Loading

Description

Small PR to add tracing targets to stage logs.

@refcell refcell changed the title chore(derive): add targets to stage logs chore(derive): Stage Log Targets Jun 24, 2024
@refcell Graphite App
Copy link
Collaborator Author

refcell commented Jun 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby June 24, 2024 22:28
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate labels Jun 24, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 24, 2024 22:28
@refcell refcell self-assigned this Jun 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (c024853) to head (77c5694).

Files Patch % Lines
crates/derive/src/stages/batch_queue.rs 55.5% 4 Missing ⚠️
crates/derive/src/stages/channel_reader.rs 25.0% 3 Missing ⚠️
crates/derive/src/stages/channel_bank.rs 50.0% 2 Missing ⚠️
crates/derive/src/stages/attributes_queue.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clabby
clabby approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up, thanks!

@refcell refcell added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 7f1a77c Jun 25, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Closed
refcell added a commit that referenced this pull request Jun 25, 2024
@refcell
chore(derive): add targets to stage logs (#310)
390b9ce
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Closed
@clabby clabby deleted the refcell/stage-logs branch July 2, 2024 03:40
This was referenced Jul 8, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Milestone
Phase 2: Kona Derivation Pipeline
Development

Successfully merging this pull request may close these issues.
3 participants
@refcell @codecov-commenter @clabby