-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(derive): Pipeline Iterator #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
changed the title
fix(derive): bind the Pipeline trait to Iterator
fix(derive): Pipeline Iterator
Jun 27, 2024
This was referenced Jun 27, 2024
refcell
added
A-derive
Area: Derivation pipeline
M-traits
Meta: Touches Trait Abstractions
K-fix
Kind: fix
labels
Jun 27, 2024
— with
Graphite App
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
This was referenced Jun 27, 2024
clabby
approved these changes
Jun 28, 2024
refcell
force-pushed
the
refcell/channel-frame-count
branch
from
June 28, 2024 13:51
c8cb071
to
f1676a1
Compare
refcell
force-pushed
the
refcell/iterator
branch
from
June 28, 2024 13:51
cf2f421
to
a709218
Compare
refcell
force-pushed
the
refcell/iterator
branch
from
June 28, 2024 13:58
a709218
to
f89e215
Compare
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binds the
Pipeline
trait to be anIterator<Item = L2AttributesWithParent>
.This replaces the custom
next()
method definition with thecore::iter::Iterator
trait that allows for greater fluency.