Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Pipeline Iterator #334

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(derive): Pipeline Iterator #334

merged 1 commit into from
Jun 28, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 27, 2024

Description

Binds the Pipeline trait to be an Iterator<Item = L2AttributesWithParent>.

This replaces the custom next() method definition with the core::iter::Iterator trait that allows for greater fluency.

@refcell refcell changed the title fix(derive): bind the Pipeline trait to Iterator fix(derive): Pipeline Iterator Jun 27, 2024
@refcell refcell requested a review from clabby June 27, 2024 18:52
@refcell refcell added A-derive Area: Derivation pipeline M-traits Meta: Touches Trait Abstractions K-fix Kind: fix labels Jun 27, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 27, 2024 18:52
@refcell refcell self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.6%. Comparing base (c87fe1d) to head (f89e215).

Files Patch % Lines
crates/derive/src/pipeline/core.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the base branch from refcell/channel-frame-count to main June 28, 2024 13:58
@refcell refcell enabled auto-merge June 28, 2024 13:58
@refcell refcell added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 57a765a Jun 28, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
@clabby clabby deleted the refcell/iterator branch July 2, 2024 03:37
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
This was referenced Jul 8, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: Derivation pipeline K-fix Kind: fix M-traits Meta: Touches Trait Abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants