Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(derive): Refine Channel Frame Count Buckets #378

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 12, 2024

Description

Channel frame counts tend to max out around 20-30. Previously there were multiple buckets > 20 that just contained redundant counts. This PR refines the buckets to introspect closer into the window between [1, 20].

Copy link
Collaborator Author

refcell commented Jul 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title chore(derive): refine channel frame count buckets chore(derive): Refine Channel Frame Count Buckets Jul 12, 2024
@refcell refcell requested a review from clabby July 12, 2024 02:46
@refcell refcell added K-chore Kind: chore A-derive Area: Derivation pipeline M-metrics Meta: metric related labels Jul 12, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review July 12, 2024 02:46
@refcell refcell self-assigned this Jul 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (a78b98e) to head (94902c3).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 5e61c48 Jul 12, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: Derivation pipeline K-chore Kind: chore M-metrics Meta: metric related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants