Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run cargo hack against workspace #485

Merged
merged 2 commits into from
Sep 4, 2024
Merged

feat: Run cargo hack against workspace #485

merged 2 commits into from
Sep 4, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 4, 2024

Description

Adds a step to cargo hack the workspace.

@refcell refcell self-assigned this Sep 4, 2024
@refcell refcell requested a review from clabby September 4, 2024 19:14
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.2%. Comparing base (858d578) to head (148f6e2).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell
Copy link
Collaborator Author

refcell commented Sep 4, 2024

Note

This should fail since #482 fixes the brekage

@refcell
Copy link
Collaborator Author

refcell commented Sep 4, 2024

Once #482 is merged, this pr can be rebased and the ci check should pass

Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significantly impressed that this passed w/ 1 feature flag mod + #482, very nice.

@clabby clabby added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 6212a1c Sep 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants