chore(workspace): Removes Primitives #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
commented
Oct 7, 2024
refcell
force-pushed
the
rf/feat/remove-primitives
branch
from
634c59a to
54ec4f3
Compare
|
Codecov isn't updating with the rebase... it's 91.5% on codecov.io |
refcell
commented
Oct 10, 2024
refcell
force-pushed
the
rf/feat/remove-primitives
branch
from
4cf20d9 to
364a8d8
Compare
refcell
force-pushed
the
rf/feat/remove-primitives
branch
2 times, most recently
from
d0f654a to
f5ab6fd
Compare
refcell
force-pushed
the
rf/feat/remove-primitives
branch
from
aa6d626 to
2cba579
Compare
refcell
commented
Oct 18, 2024
clabby
reviewed
Oct 18, 2024
clabby
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
It's finally here wowowow
Send it - would be nice to get some tickets up for the cleanups to follow:
- Move Beacon API response types to
alloy-rpc-beacon - Coverage on blob decoding (this actually feels like a great candidate for
op-alloy-protocol, given our blob encoding is a consensus construct.)
fakedev9999
pushed a commit
to fakedev9999/kona
that referenced
this pull request
Nov 5, 2024
* feat(workspace): remove primitives * fix: indexed blob hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
kona-primitives, in favor of upstream alloy types.Metadata
Closes #516