Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Replace Decimal with int representation #65

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

antonagestam
Copy link
Owner

This commit changes to use plain int as internal value type for Money and Overdraft.

@antonagestam antonagestam marked this pull request as ready for review October 8, 2023 22:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #65 (2a27dca) into main (2a1a00e) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         9    +1     
  Lines         2368      2403   +35     
  Branches       411       422   +11     
=========================================
+ Hits          2368      2403   +35     
Files Coverage Δ
src/immoney/_base.py 100.00% <100.00%> (ø)
src/immoney/_cache.py 100.00% <100.00%> (ø)
src/immoney/_parsers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@antonagestam antonagestam enabled auto-merge (squash) October 8, 2023 22:09
@antonagestam antonagestam force-pushed the feature/decimal-for-presentation-only branch 2 times, most recently from b8fed2f to 1602fa9 Compare October 8, 2023 22:20
This commit changes to use plain int as internal value type for Money
and Overdraft.

Round.ZERO_FIVE_UP was removed.
@antonagestam antonagestam force-pushed the feature/decimal-for-presentation-only branch from 1602fa9 to 2a27dca Compare October 8, 2023 22:44
@antonagestam antonagestam merged commit 2a92af2 into main Oct 8, 2023
6 checks passed
@antonagestam antonagestam deleted the feature/decimal-for-presentation-only branch October 8, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Represent Money value as subunit integer, expose decimal as property
2 participants