Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve /auth API endpoints #33

Merged
merged 1 commit into from
May 23, 2023
Merged

Improve /auth API endpoints #33

merged 1 commit into from
May 23, 2023

Conversation

antoninbas
Copy link
Contributor

  • Use POST instead of GET for /login and /logout. This seems to be better practice, but it probably doesn't make a big difference with our current design.
  • Support refresh token passed in Authorization header for /refresh_token endpoint. This is mostly for the benefit of non-browser clients.
  • Use a session cookie to store the refresh token instead of a fixed lifetime based on token expiry.

@antoninbas
Improve /auth API endpoints
e89ceb5 
* Use POST instead of GET for /login and /logout. This seems to be
  better practice, but it probably doesn't make a big difference with
  our current design.
* Support refresh token passed in Authorization header for
  /refresh_token endpoint. This is mostly for the benefit of non-browser
  clients.
* Use a session cookie to store the refresh token instead of a fixed
  lifetime based on token expiry.

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas merged commit 9d2a9d1 into antrea-io:main May 23, 2023
@antoninbas antoninbas deleted the improve-auth-apis branch May 23, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antoninbas