Traceflow improvements in web client #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoninbas
commented
May 10, 2024
•
antoninbas
commented
- Add egressNode and srcPodIP fields to TraceflowObservation. These fields were added to the API recently. We show egressNode in the generated result graph when appropriate, but we don't use srcPodIP at the moment.
- Use 53 (DNS) as the default port for UDP instead of 43. I believe 43 was a typo...
- More uniform capitalization of error messages for Traceflow form validation.
- Make dstPort required for non-live Traceflow.
* Add egressNode and srcPodIP fields to TraceflowObservation. These fields were added to the API recently. We show egressNode in the generated result graph when appropriate, but we don't use srcPodIP at the moment. * Use 53 (DNS) as the default port for UDP instead of 43. I believe 43 was a typo... * More uniform capitalization of error messages for Traceflow form validation. * Make dstPort required for non-live Traceflow. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
web-client-traceflow-improvements
branch
from
1226bbe to
16579f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.