Skip to content

Commit

Permalink
Remove --since-time Flag in IPFIX Collector Log Retrieval
Browse files Browse the repository at this point in the history
In this commit we eliminate the `--since-time` flag utilized when retrieving logs from the IPFIX collector Pod in the e2e test. We also use labels to filter records in the IPFIX collector Pod and the ClickHouse instead of using timestamp to do that.

The reason is that there is a potential time discrepancy between the testbed and the Kubernetes nodes or the time discrepancy between the k8s nodes, and using this flag/timestamp might prevent us from obtaining the desired logs.

For flows requiring correlation, such as inter-node traffic, if the records aren't received from both nodes, the record will remain in the queue for up to 3 cycles of aggregatorActiveFlowRecordTimeout.
We've set the timeout to exporterActiveFlowExportTimeout plus aggregatorActiveFlowRecordTimeout multiplied by 3 to ensure stability in the interNode test and facilitate the timely observation of removal messages.

Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
  • Loading branch information
yuntanghsu committed Nov 23, 2023
1 parent ac314f0 commit 6325d6d
Show file tree
Hide file tree
Showing 3 changed files with 127 additions and 81 deletions.
2 changes: 1 addition & 1 deletion ci/kind/test-e2e-kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ function run_test {
fi

if $flow_visibility; then
timeout="20m"
timeout="25m"
flow_visibility_args="-run=TestFlowAggregator --flow-visibility"
if $coverage; then
$FLOWAGGREGATOR_YML_CMD --coverage | docker exec -i kind-control-plane dd of=/root/flow-aggregator-coverage.yml
Expand Down
Loading

0 comments on commit 6325d6d

Please sign in to comment.