-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish antctl binaries for different platforms in releases #312
Comments
Hi @antoninbas, it looks like binaries in the release page are uploaded manually? If so, I think there is no change that should be involved in the repo? |
yes I will take care of publishing the antctl binaries for linux / macOS / windows for upcoming releases we do not publish any binary at the moment, just the antrea manifest, but that will change starting with 0.3.0 it will be manual at first (I'll add a script to the repo, a bit like what Kind does), but we can look into automating it later (maybe using something like goreleaser as a starting point?) |
We discussed this at the 01/22/2020 Antrea community meeting. We decided to postpone publishing the binaries until the next release for 2 reasons:
|
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes antrea-io#312
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes antrea-io#312
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes antrea-io#312
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes antrea-io#312
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes #312
Describe the problem/challenge you have
The antctl binaries are not included in release publish.
Describe the solution you'd like
Publish antctl binaries for different platforms in releases.
Also publish the antctl deploy yaml and image when #310 is implemented.
Anything else you would like to add?
Need to consider the name of antctl for each platform
The text was updated successfully, but these errors were encountered: