Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Antrea 2.0] Promote APIs to appropriate versions and feature gates to appropriate stages #5068

Closed
15 of 27 tasks
luolanzone opened this issue Jun 1, 2023 · 5 comments
Closed
15 of 27 tasks
Labels
kind/design Categorizes issue or PR as related to design.

Comments

@luolanzone
Copy link
Contributor

luolanzone commented Jun 1, 2023

Describe what you are trying to solve
This is a sub-task of issue #4832.

Describe the solution you have in mind

  • API Version
    A few APIs need to be upgraded from alpha to beta, meanwhile, it's a good chance to revisit the code when perform the upgrade, a few known APIs codes need to be cleanup.
  • Feature Gates
    There are some features which may be promising to next stage before or in v2.0:
    (Add or keep the toggle for some GA features)

Following features require more discussions before promoting:

  • AntreaPolicy: Beta -> GA? (could it be confusing if the API stage doesn't match feature gate stage?)
  • Traceflow: Beta -> GA? (as we are considering graduating its API to v1)
  • ServiceExternalIP: Alpha(1.5) -> Beta? (Has a bug need to be resolved, and a new feature is from user)
  • IPsecCertAuth: Alpha -> Beta? (need more tests and confirmation about this feature)
  • ExternalNode: Alpha -> Beta? (two on-going issues on Azure)
  • SupportBundleCollection: Alpha -> Beta? (It's mainly for ExternalNode, CRD is stable, more protocols beside sftp?)
  • FlowExporter: Alpha -> Beta? (lots of changes on going, may need more discussion, check the scale test result)
  • L7NetworkPolicy: Alpha -> Beta? (a bug about checksum need to be resolved)
  • NetworkPolicyStats: Beta (1.2)-> GA?
  • NodePortLocal: Beta (1.4) -> GA? Promote feature gate NodePortLocal to GA #5491
  • AntreaIPAM: Alpha (1.4) -> Beta?
  • TrafficControl: Alpha (1.7) -> Beta ?
  • SecondaryNetwork: Alpha (1.5) -> Beta?
@luolanzone luolanzone added the kind/design Categorizes issue or PR as related to design. label Jun 1, 2023
@luolanzone luolanzone mentioned this issue Jun 1, 2023
9 tasks
@luolanzone
Copy link
Contributor Author

@GraysonWu I assigned below APIs promotion to you considering they are highly bound to NP, please let me know if you have bandwidth issue. Thanks.

NetworkPolicy / ClusterNetworkPolicy: v1alpha1 -> v1beta1 (@GraysonWu )
Tier: v1alpha1 -> v1beta1 (@GraysonWu )
ClusterGroup/Group: v1alpha3 -> v1beta1 (@GraysonWu )

@luolanzone
Copy link
Contributor Author

We need a follow up PR to add deprecated for the old versions if we plan to increase the min supported version to v1.19
please refer to this comment #5108 (comment).

@luolanzone
Copy link
Contributor Author

@antoninbas @jianjuns @tnqn Regarding the feature gate promotion, we have a few candidates as the list in the issue summary, could you help to check if it's good to go to promote AntreaProxy and EndpointSlice to GA? The remaining items are also listed with question mark. Probably we need more discussion for them.

@antoninbas
Copy link
Contributor

I am fine with AntreaProxy and EndpointSlice graduation to GA, but maybe we want to keep a boolean field in the config as a way for users to disable AntreaProxy?

For the others, maybe we can discuss it first at the next community meeting?

antoninbas pushed a commit that referenced this issue Oct 24, 2023
A new antreaProxy.enable config toggle is added (defaults to true)
for users who need to disable AntreaProxy.

For #5068

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@luolanzone
Copy link
Contributor Author

The other features remained in this issues will be kept the same stage for now. No further changes are required in this issue, so close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

No branches or pull requests

2 participants