Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Namespaced Group Membership and Association query API #5269

Closed
chidambaramgvmware opened this issue Jul 18, 2023 · 2 comments · Fixed by #5380
Closed

Add Namespaced Group Membership and Association query API #5269

chidambaramgvmware opened this issue Jul 18, 2023 · 2 comments · Fixed by #5380
Assignees
@qiyueyao
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Antrea v1.14 release

Comments

@chidambaramgvmware
Copy link

Describe the problem/challenge you have
Currently, Antrea supports ClusterGroup and Group CRDs. But, the effective group membership API is available only for ClusterGroups in the form of clustergroupmembers.controlplane.antrea.io

Describe the solution you'd like
Requesting a group membership query API for Namespaced Groups as well similar to ClusterGroups so that Namespaced Group consumers can query the group members at runtime. groupmembers.controlplane.antrea.io or namespacedgroupmembers.controlplane.antrea.io

Anything else you would like to add?
N/A
@chidambaramgvmware chidambaramgvmware added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2023
@Dyanngg Dyanngg added this to the Antrea v1.14 release milestone Jul 19, 2023
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 10, 2023
@qiyueyao
Namespaced Group membership API
33c8882 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
@qiyueyao qiyueyao mentioned this issue Aug 10, 2023
Merged
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 10, 2023
@qiyueyao
Namespaced Group membership API
baa092e 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 10, 2023
@qiyueyao
Namespaced Group membership API
0a79296 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 10, 2023
@qiyueyao
Namespaced Group membership API
6203a0f 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
@chidambaramgvmware
Copy link
Author

Hi @qiyueyao , Could you confirm if your change also takes care of the reverse mapping, given a Pod or ExternalEntity resource returns the Groups that the resource is associated to?

@qiyueyao
Copy link
Contributor

From testing and code logic, the Group Association query API works as expected, which returns the associated namespaced groups.

qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 24, 2023
@qiyueyao
Namespaced Group membership API
2f4e2a8 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 24, 2023
@qiyueyao
Namespaced Group membership API
064b669 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao added a commit to qiyueyao/antrea that referenced this issue Aug 28, 2023
@qiyueyao
Namespaced Group membership API
b1f4de7 
Currently Antrea supports ClusterGroup and namespaced Group
CRD, but only provides API for ClusterGroup membership.

This solution adds membership API for namespaced Group at
namespacedgroupmembers.controlplane.antrea.io. The group
association API is still available for both ClusterGroup and
namespaced Group.

Fixes antrea-io#5269

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiyueyao qiyueyao

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Antrea v1.14 release
Development

Successfully merging a pull request may close this issue.

Add Namespaced Group Membership API qiyueyao/antrea
3 participants
@Dyanngg @qiyueyao @chidambaramgvmware