-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the IPPool subnet and ExteranalIPPool subnet definition #5961
Comments
#5799 (comment) has some context. The goal is to make
I'm not sure if we still want to have @jianjuns may have more comments. |
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. 2. Promote IPPool CRD to v1beta1 Issue:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. 2. Promote IPPool CRD to v1beta1 Fixese:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. 2. Promote IPPool CRD to v1beta1 Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. 2. Promote IPPool CRD to v1beta1 Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. 2. Promote IPPool CRD to v1beta1 3. Add conversion webhook to IPPool Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. With this change, one IPPool can have multiple IP Ranges, but can only have one SubnetInfo. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 2. Promote IPPool CRD to v1beta1 3. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. With this change, one IPPool can have multiple IP Ranges, but can only have one SubnetInfo. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 2. Promote IPPool CRD to v1beta1 3. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. With this change, one IPPool can have multiple IP Ranges, but can only have one SubnetInfo. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 2. Promote IPPool CRD to v1beta1 3. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool. With this change, one IPPool can have multiple IP Ranges, but can only have one SubnetInfo. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. 6. Fix Antrea-native secondary network tests by using the correct image. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
There are two CRDs in Antrea to define an IP Pool including
ippools.crd.antrea.io
andexternalippools.crd.antrea.io
. InIPPool
definition, there is aIPPoolSpec
defined, this old definition can be refined to use the same way asExternalIPPool
to define IP ranges and subnet to be consistent since they actually have the same purpose.The version of
IPPool
CRD may be upgraded tov1beta1
with this change. @jianjuns do you have any comment for the version change? Thanks.The text was updated successfully, but these errors were encountered: