Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy #1015

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy #1015

merged 1 commit into from
Aug 7, 2020

Conversation

suwang48404
Copy link
Contributor

Kube-Proxy is not used in these modes for pod-to-service traffic.

@suwang48404 suwang48404 requested review from tnqn and jianjuns July 31, 2020 20:24
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@suwang48404 suwang48404 requested a review from antoninbas July 31, 2020 20:24
@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404 suwang48404 force-pushed the migrate-modes branch 3 times, most recently from b87bcd0 to ceed160 Compare July 31, 2020 21:03
@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

@jianjuns @tnqn

Hello, kind reminder.

jianjuns
jianjuns reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suwang48404 for the work. Great to see we cleaned the code a lot!

A few minor comments and questions.

docs/policy-only.md Show resolved Hide resolved
pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved
pkg/agent/route/route_linux.go Show resolved Hide resolved
pkg/agent/route/route_linux.go Show resolved Hide resolved
pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved
@suwang48404 suwang48404 force-pushed the migrate-modes branch 2 times, most recently from ba5b9ce to 1b350f4 Compare August 4, 2020 20:17
tnqn
tnqn reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suwang48404 thanks for the work! Code LGTM, just have two questions.

pkg/agent/route/route_linux.go Show resolved Hide resolved
test/integration/agent/route_test.go Outdated Show resolved Hide resolved
@tnqn
Copy link
Member

tnqn commented Aug 5, 2020

nit: could you remove trailing period in the commit message title to align with common style?https://github.com/golang/go/wiki/CommitMessage#commit-messages

@suwang48404 suwang48404 changed the title Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy. Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy Aug 5, 2020
@jianjuns
Copy link
Contributor

jianjuns commented Aug 5, 2020

@suwang48404 : in case you did not see it, there is a conflict in route_test.go that you need to resolve.

@suwang48404
Copy link
Contributor Author

Hi @jianjuns, thx for the heads-up. Resolved.

@suwang48404 : in case you did not see it, there is a conflict in route_test.go that you need to resolve.

tnqn
tnqn previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

/test-windows-conformance

/test-windows-networkpolicy

@suwang48404
Copy link
Contributor Author

/test-e2e

jianjuns
jianjuns previously approved these changes Aug 6, 2020
View reviewed changes
@suwang48404
Copy link
Contributor Author

/test-windows-conformance

/test-windows-networkpolicy

@suwang48404
Copy link
Contributor Author

/test-windows-networkpolicy

@tnqn
Copy link
Member

tnqn commented Aug 7, 2020

@suwang48404 sorry, there is another merge conflict because I merged PR #1047, could you resolve it again? I will take care of CI testing and merging it after that.

Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy
8ba3f8c 
Kube-Proxy is not used in these modes for pod-to-service traffic.
@suwang48404 suwang48404 dismissed stale reviews from jianjuns and tnqn via 8ba3f8c August 7, 2020 05:46
@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

@suwang48404 sorry, there is another merge conflict because I merged PR #1047, could you resolve it again? I will take care of CI testing and merging it after that.

hi @tnqn merged. thx for helping out with the CI process. I had some trouble running e2e on windows, hopefully better luck to u.

@tnqn
Copy link
Member

tnqn commented Aug 7, 2020

/test-windows-conformance

@tnqn tnqn merged commit 2e3e155 into antrea-io:master Aug 7, 2020
@antoninbas antoninbas added this to the Antrea v0.9.0 release milestone Aug 7, 2020
@jianjuns jianjuns mentioned this pull request Aug 25, 2020
Closed
@jianjuns jianjuns mentioned this pull request Sep 17, 2020
Closed
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@suwang48404 @GraysonWu
Move noEncap/Hybrid/Policy-Only mode to use Antrea-proxy (antrea-io#1015
d751c9d 
)

Kube-Proxy is not used in these modes for pod-to-service traffic.
@suwang48404 suwang48404 deleted the migrate-modes branch October 30, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@jianjuns jianjuns jianjuns left review comments

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.9.0 release
Development

Successfully merging this pull request may close these issues.
6 participants
@suwang48404 @antrea-bot @tnqn @jianjuns @antoninbas @vmwclabot