Add a new e2e provider to make test running on remote cluster #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
weiqiangt
force-pushed
the
weiqiangt/remote-e2e-provider
branch
from
99df0d9 to
808b363
Compare
antoninbas
reviewed
Nov 29, 2019
test/e2e/providers/remote.go
Outdated
| var ( | ||
| homedir, _ = os.UserHomeDir() | ||
| sshConfig = flag.String("remote.sshconfig", path.Join(homedir, ".ssh", "config"), "Path of the sshconfig") | ||
| masterHostname = flag.String("remote.master", "", "Hostname of the master node of the kubernetes cluster") |
There was a problem hiding this comment.
maybe we can do without this (like the vagrant provider) even though it means parsing the SSH config for every call to RunCommandOnNode? That would simplify usage with no significant drawback. What do you think?
weiqiangt
force-pushed
the
weiqiangt/remote-e2e-provider
branch
from
808b363 to
f8799d6
Compare
Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
weiqiangt
force-pushed
the
weiqiangt/remote-e2e-provider
branch
from
f8799d6 to
bbefcdd
Compare
Co-Authored-By: Antonin Bas <antonin.bas@gmail.com>
Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
tnqn
reviewed
Dec 2, 2019
Addressing comments Signed-off-by: Weiqiang TANG <weiqiangt@vmware.com>
|
Better to update #158 (comment) as you have removed |
Thanks. |
|
/test-e2e |
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Jul 2, 2021
Delete the unrequired method of deleting record from record map without lock. Add a method to get the flow updated time for flow given flow key
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Jul 2, 2021
Reverting this commit 7c0a0ae. Reason is the PR(antrea-io#1949) that depends on this commit is not yet ready. And to move the tag of go-ipfix in Antrea for other PRs this commit should be present in the latest release tags. Therefore, reverting this.
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Jul 2, 2021
Delete the unrequired method of deleting record from record map without lock. Add a method to get the flow updated time for flow given flow key
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Jul 2, 2021
Delete the unrequired method of deleting record from record map without lock. Add a method to get the flow updated time for flow given flow key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the remote provider which accepts sshconfig file and kubeconfig file to run the e2e test on a remote Kubernetes cluster.
The provider accept two new flags:
remote.kubeconfig: Path of the kubeconfig of the cluster in local machineremote.sshconfig: Path of the sshconfig