Add clientset for ClusterGroupMembers and GroupAssociation #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
previously approved these changes
Apr 27, 2021
Codecov Report
@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
+ Coverage 61.26% 65.28% +4.02%
==========================================
Files 269 269
Lines 20424 20791 +367
==========================================
+ Hits 12512 13574 +1062
+ Misses 6624 5831 -793
- Partials 1288 1386 +98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
reviewed
Apr 28, 2021
| // ClusterGroupMembersesGetter has a method to return a ClusterGroupMembersInterface. | ||
| // A group's client should implement this interface. | ||
| type ClusterGroupMembersesGetter interface { | ||
| ClusterGroupMemberses() ClusterGroupMembersInterface |
There was a problem hiding this comment.
You can specify "--plural-exceptions" when calling client-gen to avoid it
There was a problem hiding this comment.
Thanks for coming to the rescue, as always :) Updated
Dyanngg
force-pushed
the
cg-member-assoc-clientset
branch
from
7d8bcd8 to
4f59a5a
Compare
|
/test-all |
|
/test-networkpolicy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance programmatic access to the ClusterGroupMembers and GroupAssociation resources.
Both can now be accessed via the Antrea clientset
Note that the interface for ClusterGroupMembers is awkwardly named: this is because in controlplane/v1beta2/types.go the resource itself is defined in its plural form, which is out of the convention for client generation. In future controlplane API group upgrade, we should consider updating the
ClusterGroupMemberstype toClusterGroupMember.