Remove EnableTLSConfig from antrea agent #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
+ Coverage 60.92% 61.62% +0.69%
==========================================
Files 273 273
Lines 20662 20663 +1
==========================================
+ Hits 12589 12734 +145
+ Misses 6752 6593 -159
- Partials 1321 1336 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
srikartati
reviewed
May 19, 2021
test/e2e/fixtures.go
Outdated
| @@ -189,6 +189,7 @@ func setupTestWithIPFIXCollector(tb testing.TB) (*TestData, bool, bool, error) { | |||
| } | |||
| if testOptions.providerName == "kind" { | |||
| // In Kind cluster, there are issues with DNS name resolution on worker nodes. | |||
| // We will skip TLS testing for Kind cluster because the server certificate is generated with Flow aggregator's DNS name | |||
There was a problem hiding this comment.
As part of Flow Aggregator windows support #2138, we are supporting cluster IP in the certificate. Can we enable the kind test with TLS?
| # If no PROTO is given, we consider "tcp" as default. We support "tcp" and "udp" | ||
| # L4 transport protocols. | ||
| #flowCollectorAddr: "flow-aggregator.flow-aggregator.svc:4739:tcp" | ||
| # If no PROTO is given, we consider "tls" as default. We support "tls", "tcp" and |
There was a problem hiding this comment.
We should change for windows yaml too.
zyiou
force-pushed
the
zyiou/configTLS
branch
2 times, most recently
from
15d2585 to
39aa316
Compare
antoninbas
previously approved these changes
May 21, 2021
|
/test-all |
|
/test-e2e |
|
/test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed,
EnableTLSToFlowAggregatorconfig is unnecessary for Flow Exporter. We can usetlsin protocol ofFlowCollectorAddrinstead to enable encryption for communication between flow exporter to flow aggregator.