Add selecting egress's owner node and assign egress-ip to owner node #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
- Coverage 61.75% 61.41% -0.34%
==========================================
Files 278 281 +3
Lines 21255 21581 +326
==========================================
+ Hits 13125 13254 +129
- Misses 6770 6943 +173
- Partials 1360 1384 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wenqiq
changed the title
wenqiq
force-pushed
the
egress-policy-failover
branch
6 times, most recently
from
f204201 to
0bbc99f
Compare
wenqiq
force-pushed
the
egress-policy-failover
branch
4 times, most recently
from
a7fe01a to
2135405
Compare
wenqiq
force-pushed
the
egress-policy-failover
branch
2 times, most recently
from
f3a9c29 to
a3de615
Compare
A cluster will created in background when egress feature turn on, once local node labels matches the ExternalIPPool nodeSelectors, it will join cluster, in the same way, local node will leave cluster when node labels or ExternalIPPool nodeSelectors updated and not matched. Each node joined in cluster hold the same consistent hash map, when new node join cluster, add node name as new key to the hash ring, when a node leave the cluster, the consistent hash map will update. Signed-off-by: wenqiq <wenqiq@vmware.com>
wenqiq
force-pushed
the
egress-policy-failover
branch
from
a3de615 to
a86be3b
Compare
wenqiq
changed the title
1.Assign a owner node for egress which with a valid externalIPPool 2.Add egress status of api, when egress has assigned a owner node and egressIP has assigned, the egress status will updated, egress status is the owner node name Signed-off-by: wenqiq <wenqiq@vmware.com>
wenqiq
force-pushed
the
egress-policy-failover
branch
from
a86be3b to
4692284
Compare
xliuxu
reviewed
Jun 30, 2021
| if err != nil { | ||
| return err | ||
| } | ||
| if err := assignEgressIP(addr, link); err != nil { |
There was a problem hiding this comment.
could be simplified by return assignEgressIP(addr, link)
There was a problem hiding this comment.
Thanks, could you please help to review this PR #2186? Some code has been deprecated in this PR.
|
All codes have been merged in PR #2186. Close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selecting egress's owner node and assign egress-ip to owner node
1.Assign a owner node for egress which with a valid externalIPPool
2.Add egress status of api, when egress has assigned a owner node and egressIP has assigned,
the egress status will updated, egress status is the owner node name
For #2128