Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support various pod traffic encapsulation mode #340

Merged
merged 3 commits into from
Feb 11, 2020
Merged

support various pod traffic encapsulation mode #340

merged 3 commits into from
Feb 11, 2020

Conversation

suwang48404
Copy link
Contributor

@suwang48404 suwang48404 commented Jan 22, 2020 •
edited
Loading

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@suwang48404 suwang48404 changed the title WIP: suport various pod traffic encapsulation mode WIP: support various pod traffic encapsulation mode Jan 22, 2020
@suwang48404 suwang48404 force-pushed the noencap branch 2 times, most recently from 175b900 to 5bffd96 Compare January 23, 2020 02:45
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@suwang48404
Copy link
Contributor Author

/test-e2e
/test-conformance
/test-networkpolicy

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

/test-e2e

@antoninbas
Copy link
Contributor

/test-all

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404 suwang48404 force-pushed the noencap branch 10 times, most recently from 5fcf731 to e2e9f8d Compare January 24, 2020 08:54
@suwang48404 suwang48404 force-pushed the noencap branch 2 times, most recently from 9936850 to c83a1d3 Compare February 11, 2020 04:23
@suwang48404
Copy link
Contributor Author

/test-all

antoninbas
antoninbas reviewed Feb 11, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment for the test script.

Otherwise, the changes (including changes to kind.yml) look good to me.

ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved
.github/workflows/kind.yml Show resolved Hide resolved
@suwang48404 suwang48404 force-pushed the noencap branch 2 times, most recently from 82bbc8b to c892faf Compare February 11, 2020 18:51
Su Wang added 2 commits February 11, 2020 10:52
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

incorporate pod traffic encapsulation mode into kind e2e tests.
b774f32 
- kind e2e tests now runs a separete e2e on each of encap mode: encap, hybrid, noEncap
- misc: move test-integratin to test-integration-docker to allow more
  disruptive integration tests in futher.
@suwang48404
Copy link
Contributor Author

/test-all

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@suwang48404
Copy link
Contributor Author

/test-all

antoninbas
antoninbas reviewed Feb 11, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianjuns I'm done with my review. Things look good on my side.

@suwang48404
Copy link
Contributor Author

/test-conformance

@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404
Copy link
Contributor Author

/test-conformance

1 similar comment
@suwang48404
Copy link
Contributor Author

/test-conformance

@suwang48404
Copy link
Contributor Author

/test-conformance
/test-networkpolicy

@suwang48404
Copy link
Contributor Author

/test-conformance

@suwang48404
Copy link
Contributor Author

/test-networkpolicy

@suwang48404
Copy link
Contributor Author

@jianjuns can u provide approval now?

jianjuns
jianjuns approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great we completed review of this big PR. Great work @suwang48404 and all reviewers!

@jianjuns jianjuns merged commit 3127843 into antrea-io:master Feb 11, 2020
@suwang48404 suwang48404 mentioned this pull request Feb 11, 2020
Closed
@suwang48404 suwang48404 deleted the noencap branch March 16, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn left review comments

@wenyingd wenyingd wenyingd left review comments

@antoninbas antoninbas antoninbas left review comments

@jianjuns jianjuns jianjuns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@suwang48404 @antrea-bot @antoninbas @jianjuns @lzhecheng @tnqn @wenyingd @vmwclabot