Improve antctl features in flow-aggregator #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntanghsu
added
the
area/flow-visibility
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
8cc2899
to
f8453d8
Compare
Codecov Report
@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
- Coverage 49.03% 45.69% -3.35%
==========================================
Files 261 256 -5
Lines 39245 38216 -1029
==========================================
- Hits 19245 17462 -1783
- Misses 18128 18994 +866
+ Partials 1872 1760 -112
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
4 times, most recently
from
892893a
to
03cc4c6
Compare
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
03cc4c6
to
a0b1803
Compare
|
This pull request introduces 1 alert when merging a0b1803 into 2ab80d0 - view on LGTM.com new alerts:
|
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
a0b1803
to
7eeb50b
Compare
|
This pull request introduces 1 alert when merging 7eeb50b into 2ab80d0 - view on LGTM.com new alerts:
|
antoninbas
reviewed
Apr 15, 2022
There was a problem hiding this comment.
IMO, there is a major issue with this PR: these commands are not troubleshooting commands, there are used to update the FlowAggregator configuration, yet changes made through antctl are not persistent (if the FlowAggregator Pod restarts, these changes will be lost) and they conflict with the "source of truth" that would be the ConfigMap. I don't think that's right, and we had the same issue in the past with the Antrea configuration.
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
3 times, most recently
from
7f49f4f
to
2492701
Compare
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
4 times, most recently
from
3c2b293
to
c257785
Compare
annakhm
reviewed
Apr 19, 2022
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
13 times, most recently
from
154f29d
to
1317491
Compare
antoninbas
reviewed
Jun 23, 2022
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
3 times, most recently
from
c3d9b00
to
85c1fd5
Compare
antoninbas
reviewed
Jun 27, 2022
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
85c1fd5
to
b9bb280
Compare
antoninbas
reviewed
Jun 27, 2022
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
b9bb280
to
63a4421
Compare
1. Add “antctl set flow-aggregator” command for antctl in order to update clickhouse/flow-collector related parameters. 2. “antctl set flow-aggregator” will directly mutate the volume configMap of flow-aggregator 3. Mounted ConfigMap will be updated in 1min if there is a modification of volume configMap 4. Create watcher in flow-aggregator pod to watch mounted configMap and let fa pod react to the changes 5. “antctl set flow-aggregator” can only be used in flow-aggregator pod currently. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
antctl_update_clickhouse
branch
from
63a4421
to
e9dad14
Compare
|
/test-conformance |
|
/test-conformance |
antoninbas
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing clickhouse/flow-collector related parameters at runtime and update configmap.
Enable ClickHouse
$ antctl set flow-aggregator clickHouse.enable=true
Update ClickHouse database
$ antctl set flow-aggregator clickHouse.database=name
Update ClickHouse databaseURL
$ antctl set flow-aggregator clickHouse.databaseURL=http://xxxxx
Update ClickHouse debug
$ antctl set flow-aggregator clickHouse.debug=true
Update ClickHouse compress
$ antctl set flow-aggregator clickHouse.compress=true
Update ClickHouse commitInterval
$ antctl set flow-aggregator clickHouse.commitInterval=10s
Update ClickHouse ttl (unit in second)
$ antctl set flow-aggregator clickHouse.ttl=100
Update IPFIX Flow Collector address
$ antctl set flow-aggregator flowCollector.address=:[:]
Enable IPFIX Flow Collector
$ antctl set flow-aggregator flowCollector.enable=true
Signed-off-by: Yun-Tang Hsu hsuy@vmware.com