[Windows]Connect to ovsdb-server using named pipe #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
weiqiangt
reviewed
Feb 14, 2020
pkg/ovs/ovsconfig/default.go
Outdated
| defaultConnNetwork = "unix" | ||
| defaultConnAddress = "/run/openvswitch/db.sock" | ||
| // Wait up to 1 second when get port | ||
| defaultGetPortTimeout = 1000 |
There was a problem hiding this comment.
nit: use
time.Second.
Thanks Weiqiang and Jianjun. Done
pkg/ovs/ovsconfig/default_windows.go
Outdated
| defaultConnAddress = `\\.\pipe\C:openvswitchvarrunopenvswitchdb.sock` | ||
| // Wait up to 2 seconds when get port, the operation of port creation | ||
| // cost more time on Windows platform than on Linux | ||
| defaultGetPortTimeout = 2000 |
There was a problem hiding this comment.
2 * time.Second
Done
jianjuns
reviewed
Feb 15, 2020
pkg/ovs/ovsconfig/default_windows.go
Outdated
| defaultConnNetwork = "winpipe" | ||
| defaultConnAddress = `\\.\pipe\C:openvswitchvarrunopenvswitchdb.sock` | ||
| // Wait up to 2 seconds when get port, the operation of port creation | ||
| // cost more time on Windows platform than on Linux |
There was a problem hiding this comment.
cost more time -> takes longer
Add '.' after Linux.
There was a problem hiding this comment.
cost more time -> takes longer
Add '.' after Linux.
Thanks Jianjun. Done.
pkg/ovs/ovsconfig/default.go
Outdated
| defaultConnNetwork = "unix" | ||
| defaultConnAddress = "/run/openvswitch/db.sock" | ||
| // Wait up to 1 second when get port | ||
| defaultGetPortTimeout = 1000 |
|
/test-all |
ruicao93
force-pushed
the
windows
branch
2 times, most recently
from
88dd5d3 to
4c4fcec
Compare
|
/test-all |
2 similar comments
|
/test-all |
|
/test-all |
|
/test-all |
|
/test-all |
|
/test-e2e |
|
/test-all |
2 similar comments
|
/test-all |
|
/test-all |
|
/test-networkpolicy |
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
jianjuns
approved these changes
Feb 20, 2020
|
/test-e2e |
1 similar comment
|
/test-e2e |
ruicao93
added a commit
to ruicao93/antrea
that referenced
this pull request
May 27, 2020
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
ruicao93
added a commit
that referenced
this pull request
May 27, 2020
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman
pushed a commit
to McCodeman/antrea
that referenced
this pull request
Jun 2, 2020
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman
pushed a commit
that referenced
this pull request
Jun 2, 2020
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
On windows platform, ovsdb-server listens on a named pipe by default. This patch change the connection to ovsdb-server from UDS to named pipe on windows. Signed-off-by: Rui Cao <rcao@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows platform, ovsdb-server listens on a named pipe by default.
This patch change the connection to ovsdb-server from UDS to named
pipe on windows.
Signed-off-by: Rui Cao rcao@vmware.com