Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4126: Add OFSwitch connection check to Agent's liveness probes #4446

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Dec 7, 2022

Cherry pick of #4126 on release-1.8.

#4126: Add OFSwitch connection check to Agent's liveness probes

For details on the cherry pick process, see the cherry pick requests page.

@tnqn tnqn added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #4446 (90ce18e) into release-1.8 (655129d) will decrease coverage by 2.82%.
The diff coverage is 76.78%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.8    #4446      +/-   ##
===============================================
- Coverage        65.99%   63.18%   -2.82%     
===============================================
  Files              304      305       +1     
  Lines            46634    47602     +968     
===============================================
- Hits             30778    30079     -699     
- Misses           13454    15205    +1751     
+ Partials          2402     2318      -84     
Flag Coverage Δ
integration-tests 35.15% <81.25%> (-0.03%) ⬇️
kind-e2e-tests 47.04% <86.20%> (-2.04%) ⬇️
unit-tests 44.30% <73.21%> (-0.68%) ⬇️
Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options.go 3.49% <82.35%> (ø)
pkg/agent/apiserver/apiserver.go 71.27% <100.00%> (+4.25%) ⬆️
pkg/ovs/openflow/ofctrl_bridge.go 76.09% <100.00%> (+0.56%) ⬆️

... and 58 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2023
This helps automatic recovery if some issues cause OFSwitch reconnection to
not work properly.

It also fixes a race condition between the IsConnected and SwitchConnected
methods of OFBridge and makes necessary changes to the constructor of
APIServer to allow testing.

For antrea-io#4092

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn force-pushed the automated-cherry-pick-of-#4126-upstream-release-1.8 branch from 6ceb7ce to 90ce18e Compare March 30, 2023 10:46
@tnqn
Copy link
Member Author

tnqn commented Mar 30, 2023

/skip-all

@tnqn tnqn merged commit f10ef36 into antrea-io:release-1.8 Mar 30, 2023
@tnqn tnqn deleted the automated-cherry-pick-of-#4126-upstream-release-1.8 branch March 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants