Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the message length limitation in ANP Condition #4574

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

wenyingd
Copy link
Contributor

Modify the max length of Message field in ANP Condtion to 256

Fix #4559

Signed-off-by: wenyingd wenyingd@vmware.com

Modify the max length of Message field in ANP Condtion to 256

Signed-off-by: wenyingd <wenyingd@vmware.com>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #4574 (4788d94) into main (bd683b0) will decrease coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
- Coverage   68.39%   67.33%   -1.07%     
==========================================
  Files         400      400              
  Lines       58298    58298              
==========================================
- Hits        39872    39253     -619     
- Misses      15656    16260     +604     
- Partials     2770     2785      +15     
Flag Coverage Δ *Carryforward flag
e2e-tests 38.34% <ø> (ø) Carriedforward from bd683b0
integration-tests 34.50% <ø> (-0.04%) ⬇️
kind-e2e-tests 40.95% <ø> (-6.12%) ⬇️
unit-tests 57.95% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/networkpolicy/status_controller.go 70.77% <ø> (ø)
...g/agent/controller/serviceexternalip/controller.go 35.83% <0.00%> (-33.79%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 29.62% <0.00%> (-22.23%) ⬇️
pkg/agent/ipassigner/responder/arp_responder.go 55.29% <0.00%> (-17.65%) ⬇️
...pportbundlecollection/support_bundle_controller.go 47.98% <0.00%> (-17.59%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 61.48% <0.00%> (-15.55%) ⬇️
pkg/agent/proxy/topology.go 66.66% <0.00%> (-15.16%) ⬇️
pkg/util/k8s/client.go 35.00% <0.00%> (-11.67%) ⬇️
pkg/agent/agent_linux.go 3.86% <0.00%> (-10.82%) ⬇️
pkg/agent/util/net.go 48.10% <0.00%> (-10.23%) ⬇️
... and 41 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Jan 20, 2023
@tnqn tnqn added this to the Antrea v1.11 release milestone Jan 20, 2023
@reachjainrahul
Copy link
Contributor

/LGTM

@tnqn
Copy link
Member

tnqn commented Jan 20, 2023

/skip-all

@tnqn tnqn merged commit ca4a70b into antrea-io:main Jan 20, 2023
@wenyingd wenyingd deleted the issue_4559 branch May 30, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max length of the message field in an ANP Status Condition is limited to 100
3 participants