Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #4542: Fix that TrafficControlTable is always created by default #4642

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Automated cherry pick of #4542: Fix that TrafficControlTable is always created by default #4642

merged 1 commit into from
Feb 21, 2023

Conversation

hongliangl
Copy link
Contributor

Cherry pick of #4542 on release-1.10.

#4542: Fix that TrafficControlTable is always created by default

For details on the cherry pick process, see the cherry pick requests page.

@hongliangl
Fix that TrafficControlTable is always created by default
c2b594c 
For feature NetworkPolicy in flexible pipeline, TrafficControlTable
should be created when L7 NetworkPolicy is enabled since it is used
by L7 NetworkPolicy, and TrafficControlTable shouldn't be created by
default when L7 NetworkPolicy is disabled.

This PR also refines some unit test code.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Feb 20, 2023
wenyingd
wenyingd approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongliangl
Copy link
Contributor Author

/test-all

@codecov
Copy link

codecov bot commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #4642 (c2b594c) into release-1.10 (a164765) will decrease coverage by 1.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.10    #4642      +/-   ##
================================================
- Coverage         68.01%   66.99%   -1.03%     
================================================
  Files               404      404              
  Lines             58231    58231              
================================================
- Hits              39608    39012     -596     
- Misses            15866    16497     +631     
+ Partials           2757     2722      -35
Flag Coverage Δ
integration-tests 34.60% <0.00%> (-0.01%) ⬇️
kind-e2e-tests 46.20% <100.00%> (-0.99%) ⬇️
unit-tests 56.77% <100.00%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pkg/agent/openflow/framework.go 100.00% <100.00%> (ø)
pkg/ipfix/ipfix_intermediate.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/ipfix/ipfix_collector.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/flowaggregator/certificate.go 0.00% <0.00%> (-75.53%) ⬇️
pkg/flowaggregator/exporter/utils.go 0.00% <0.00%> (-72.73%) ⬇️
pkg/flowaggregator/apiserver/apiserver.go 4.61% <0.00%> (-58.47%) ⬇️
pkg/ipfix/ipfix_process.go 31.25% <0.00%> (-50.00%) ⬇️
pkg/ipfix/ipfix_registry.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/flowaggregator/flowaggregator.go 36.62% <0.00%> (-31.80%) ⬇️
pkg/flowaggregator/exporter/ipfix.go 36.47% <0.00%> (-26.64%) ⬇️
... and 38 more

@tnqn tnqn merged commit 2f54131 into antrea-io:release-1.10 Feb 21, 2023
@hongliangl hongliangl deleted the automated-cherry-pick-of-#4542-upstream-release-1.10 branch April 4, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyingd wenyingd wenyingd approved these changes

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongliangl @wenyingd @tnqn