-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop serving v1alpha2 version of the ClusterGroup CRD #4812
Stop serving v1alpha2 version of the ClusterGroup CRD #4812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The API was scheduled for deletion a year ago. My proposal is to stop serving the API in the next release (v1.12), and remove it completely in the release after that (v1.13). If someone upgrades to Antrea v1.12 and gets errors, they can easily edit the CRD to re-enable serving for the older version (and then convert all their existing resources). Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
d69bd1e
to
7bf0aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test seems to be failing though. Let me take a look as well
@Dyanngg Yes, I need to remove the e2e tests that use the API |
E2E testcase |
Signed-off-by: Antonin Bas <abas@vmware.com>
/test-all |
} | ||
return nil, fmt.Errorf("error occurred in creating/updating ClusterGroup %s", cg.Name) | ||
} | ||
|
||
// CreateOrUpdateV1Alpha3CG is a convenience function for idempotent setup of crd/v1alpha3 ClusterGroups | ||
func (data *TestData) CreateOrUpdateV1Alpha3CG(cg *crdv1alpha3.ClusterGroup) (*crdv1alpha3.ClusterGroup, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we just rename it to CreateOrUpdateClusterGroup
then (same for the delete and builder functions), otherwise when API is graduated to v1beta this will be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. If v1beta1 is not backwards-compatible with v1alpha3, then we can always introduce the version suffix back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'd rather not change it in this PR. I see that we have the same issue for the Group
CRD, even though we ever only had one version for that one. We should probably handle them together as a separate PR, or when we introduce v1beta1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll take note on this one
* Stop serving v1alpha2 version of the ClusterGroup CRD The API was scheduled for deletion a year ago. My proposal is to stop serving the API in the next release (v1.12), and remove it completely in the release after that (v1.13). If someone upgrades to Antrea v1.12 and gets errors, they can easily edit the CRD to re-enable serving for the older version (and then convert all their existing resources). * Remove API references from e2e tests Signed-off-by: Antonin Bas <abas@vmware.com>
The API was scheduled for deletion a year ago.
My proposal is to stop serving the API in the next release (v1.12), and remove it completely in the release after that (v1.13). If someone upgrades to Antrea v1.12 and gets errors, they can easily edit the CRD to re-enable serving for the older version (and then convert all their existing resources).