Decouple Audit logging from AntreaPolicy feature gate #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
reviewed
Aug 3, 2023
Comment on lines
+436
to
+439
| MaxSize: int(o.config.AuditLogging.MaxSize), | ||
| MaxBackups: int(*o.config.AuditLogging.MaxBackups), | ||
| MaxAge: int(*o.config.AuditLogging.MaxAge), | ||
| Compress: *o.config.AuditLogging.Compress, |
There was a problem hiding this comment.
The defaulting code in cmd/antrea-agent/options.go should be updated. Otherwise antrea-agent would panic when AntreaPolicy is disabled.
Better to test it once in case there are other issues preventing K8s policy logging from working when AntreaPolicy is disabled.
There was a problem hiding this comment.
Fixed and tested with AntreaPolicy disabled.
qiyueyao
force-pushed
the
decouple-audit-logging
branch
from
f256b21 to
d510190
Compare
tnqn
reviewed
Aug 8, 2023
pkg/agent/openflow/framework.go
Outdated
| @@ -152,6 +152,10 @@ func newTable(tableName string, stage binding.StageID, pipeline binding.Pipeline | |||
| return table | |||
| } | |||
|
|
|||
| func (t *Table) GetStatus() bool { | |||
There was a problem hiding this comment.
Done, probably could wait until 5369 is merged.
tnqn
added
the
action/release-note
|
#5369 has been merged, can you rebase? |
Currently Audit logging is controlled by AntreaPolicy feature gate, but it also logs K8s NetworkPolicies. This solution decouples Audit logging with the AntreaPolicy feature gate and renames the related objects. Fixes antrea-io#5340 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao
force-pushed
the
decouple-audit-logging
branch
from
0d3e4d6 to
715d757
Compare
|
/test-all |
antoninbas
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Audit logging is controlled by AntreaPolicy feature gate, but it also logs K8s NetworkPolicies.
This solution decouples Audit logging with the AntreaPolicy feature gate and renames the related objects.
Fixes #5340