Add hostAliases to Helm values for Flow Aggregator #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntanghsu
force-pushed
the
host_aliases
branch
from
fc06c2e to
8796bbe
Compare
yuntanghsu
force-pushed
the
host_aliases
branch
from
8796bbe to
f937434
Compare
yuntanghsu
changed the title
antoninbas
reviewed
Aug 15, 2023
yuntanghsu
force-pushed
the
host_aliases
branch
2 times, most recently
from
de48fdd to
6fd6ce7
Compare
antoninbas
reviewed
Aug 15, 2023
Comment on lines
18
to
25
| {{- if .Values.hostAliases }} | ||
| hostAliases: | ||
| {{- range $v := .Values.hostAliases }} | ||
| - ip: {{ $v.ip }} | ||
| hostnames: | ||
| - {{ $v.hostname }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
this should be:
hostAliases:
{{- range .Values.hostAliases }}
- ip: {{ .ip }}
hostnames:
{{- range $hostname := .hostnames }}
- {{ $hostname }}
{{- end }}
{{- end }}I think we want to support the exact same format as the PodSpec (so multiple hostnames)
I also don't think you need conditionals
There was a problem hiding this comment.
The IDE will display a error message, stating "value is required", if I don't add the if condition. But it has no impact when applying the yaml file.
…sting. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
host_aliases
branch
from
6fd6ce7 to
16e87c4
Compare
antoninbas
approved these changes
Aug 15, 2023
antoninbas
added
area/flow-visibility/aggregator
antoninbas
changed the title
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hostAliases to Helm values for Flow Aggregator
User might want to use hostAliases field when connecting Flow Aggregator to ClickHouse through Ingress/LoadBalancer.
It is also convenient for e2e test.
Signed-off-by: Yun-Tang Hsu hsuy@vmware.com