Fix VM Agent RBAC warnings

[mengdie-song]

Recent changes for K8s Node cause VM Agent RBAC warnings regarding service and node. These warnings will flood VM Agent logs.

This change fixes the issue by only initializing the related components for K8s Node case.

Signed-off-by: Mengdie Song songm@vmware.com

[wenyingd]

The change looks good to me.

I am thinking shall we refine agent.go to cleanly split agent logic for container case and VM case, e.g., introducing a new interface for agent, making VM agent and K8s Node agent as different implementations, and leaving the general resources like kubeClient, antreaClient, OVS client in the shared functions, and constructing other informers in the dedicated implementations. Any thoughts @tnqn @antoninbas @jianjuns ?

[tnqn]

LGTM

[tnqn]

I am thinking shall we refine agent.go to cleanly split agent logic for container case and VM case, e.g., introducing a new interface for agent, making VM agent and K8s Node agent as different implementations, and leaving the general resources like kubeClient, antreaClient, OVS client in the shared functions, and constructing other informers in the dedicated implementations. Any thoughts @tnqn @antoninbas @jianjuns ?

I'm not sure which kind of interface you mean and how the implementations will look like as I don't see many things can be abstracted in the run func. I feel it may be doable to have separate runXXX funcs for the two case to sperate the code path. For example:

func run(o *Options) error {
	klog.InfoS("Starting Antrea agent", "version", version.GetFullVersion())
        // Common code
	...
        //
        if o.nodeType == config.K8sNode {
                return runK8sNode(...)
        } else {
                return runExternalNode(...)              
        }
} 

[wenyingd]

I'm not sure which kind of interface you mean and how the implementations will look like as I don't see many things can be abstracted in the run func. I feel it may be doable to have separate runXXX funcs for the two case to sperate the code path. For example:

func run(o *Options) error {
	klog.InfoS("Starting Antrea agent", "version", version.GetFullVersion())
        // Common code
	...
        //
        if o.nodeType == config.K8sNode {
                return runK8sNode(...)
        } else {
                return runExternalNode(...)              
        }
} 

It looks good to to me to use two separate funcs for the different scenarios.

[tnqn]

The commit is not signed

[mengdie-song]

@tnqn I have signed the commit, thanks.

[tnqn]

/test-all