Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows OVS Container to run on pristine Host Environment #5440

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

NamanAg30
Copy link
Contributor

for #5249

@rajnkamr rajnkamr added this to the Antrea v1.14 release milestone Aug 28, 2023
@Atish-iaf
Copy link
Contributor

@NamanAg30 please update build/yamls/windows/containerd-with-ovs/ according to changes made in this PR.

docs/windows.md Outdated Show resolved Hide resolved
$driverStatus = netcfg -q ovsext
if ($driverStatus -like '*not installed*') {
# Install OVS Driver
netcfg -l $mountPath/openvswitch/driver/ovsext.inf -c s -i OVSExt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use $OVSDriverDir\ovsext.inf here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not updated.

docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
hack/windows/Prepare-AntreaAgent.ps1 Outdated Show resolved Hide resolved
@NamanAg30 NamanAg30 force-pushed the pristinehost branch 3 times, most recently from 2430189 to 8cae24e Compare October 25, 2023 10:49
$driverStatus = netcfg -q ovsext
if ($driverStatus -like '*not installed*') {
# Install OVS Driver
netcfg -l $mountPath/openvswitch/driver/ovsext.inf -c s -i OVSExt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not updated.

docs/windows.md Outdated Show resolved Hide resolved
hack/windows/Prepare-AntreaAgent.ps1 Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the Windows documentation has become very hard for users to follow, due to the 3 supported installation methods, the different version combinations (K8s, containerd) and signed vs unsigned OVS driver. It needs to be improved. However, I am aware that this PR has been in the review process for a while, and improving the documentation is out-of-scope. So I will open an issue to track this.

docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Show resolved Hide resolved
@NamanAg30 NamanAg30 force-pushed the pristinehost branch 3 times, most recently from eb6f178 to b4ef3b1 Compare October 26, 2023 09:44
Support installation of signed ovs kernel driver from inside container when no installed on host.

Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-windows-containerd-conformance

@antoninbas antoninbas merged commit 86fe766 into antrea-io:main Oct 26, 2023
42 of 56 checks passed
@NamanAg30 NamanAg30 mentioned this pull request Oct 28, 2023
NamanAg30 added a commit to NamanAg30/antrea that referenced this pull request Oct 28, 2023
Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
NamanAg30 added a commit to NamanAg30/antrea that referenced this pull request Oct 28, 2023
Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Mar 28, 2024
…rea-io#5440)

Support installation of signed ovs kernel driver from inside container when not installed on host.

Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Apr 2, 2024
…rea-io#5440)

Support installation of signed ovs kernel driver from inside container when not installed on host.

Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
tnqn pushed a commit that referenced this pull request Apr 2, 2024
Support installation of signed ovs kernel driver from inside container when not installed on host.

Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/OS/windows Issues or PRs related to the Windows operating system. kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants