Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method DestroyIPSet in pkg/agent/util/ipset #5663

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add method DestroyIPSet in pkg/agent/util/ipset #5663

merged 1 commit into from
Nov 8, 2023

Conversation

hongliangl
Copy link
Contributor

@hongliangl hongliangl commented Nov 3, 2023 •
edited
Loading

For NodeNetworkPolicy

@hongliangl hongliangl requested a review from tnqn November 3, 2023 03:36
@hongliangl
Copy link
Contributor Author

/skip-all

@hongliangl hongliangl requested a review from luolanzone November 3, 2023 03:56
luolanzone
luolanzone previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question regarding the tool ipset, do we check if the ipset is installed or not in the Node? or it's installed in antrea agent image?

@hongliangl
Copy link
Contributor Author

LGTM, one question regarding the tool ipset, do we check if the ipset is installed or not in the Node? or it's installed in antrea agent image?

ipset is built in antrea agent image.

@hongliangl
Copy link
Contributor Author

/skip-all

@hongliangl
Add method DestroyIPSet in pkg/agent/util/ipset
f3b1e5d 
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl force-pushed the 20231103-ipset-destroy branch from 7627143 to f3b1e5d Compare November 8, 2023 05:20
@hongliangl hongliangl requested a review from tnqn November 8, 2023 05:21
@tnqn
Copy link
Member

tnqn commented Nov 8, 2023

/skip-all

@tnqn tnqn merged commit 799548c into antrea-io:main Nov 8, 2023
41 of 44 checks passed
@hongliangl hongliangl deleted the 20231103-ipset-destroy branch November 8, 2023 06:56
@hongliangl hongliangl mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@luolanzone luolanzone luolanzone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongliangl @tnqn @luolanzone