Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Traceflow API v1beta1 #5689

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Use Traceflow API v1beta1 #5689

merged 1 commit into from
Nov 15, 2023

Conversation

Atish-iaf
Copy link
Contributor

@Atish-iaf Atish-iaf commented Nov 9, 2023 •
edited
Loading

Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes #5656

Signed-off-by: Kumar Atish atish.iaf@gmail.com

@Atish-iaf Atish-iaf added area/component/antctl Issues or PRs releated to the command line interface component area/ops/traceflow Issues or PRs related to the Traceflow feature kind/bug Categorizes issue or PR as related to a bug. labels Nov 9, 2023
@Atish-iaf Atish-iaf force-pushed the update-traceflow-api-in-antctl branch from c600c26 to d5f88aa Compare November 9, 2023 10:20
@Atish-iaf Atish-iaf marked this pull request as ready for review November 9, 2023 10:51
@Atish-iaf Atish-iaf requested a review from luolanzone November 9, 2023 10:53
@rajnkamr rajnkamr added this to the Antrea v1.15 release milestone Nov 9, 2023
@luolanzone
Copy link
Contributor

/test-e2e

luolanzone
luolanzone reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the test/e2e/traceflow_test.go? It still uses v1alpha1. Please help to double check if there is any other file using the old version. Thanks.

@Atish-iaf
Copy link
Contributor Author

Could you also update the test/e2e/traceflow_test.go? It still uses v1alpha1. Please help to double check if there is any other file using the old version. Thanks.

test/e2e/traceflow_test.go has been updated in #5667

@Atish-iaf Atish-iaf requested review from antoninbas and tnqn November 14, 2023 03:51
@luolanzone
Copy link
Contributor

Could you also update the test/e2e/traceflow_test.go? It still uses v1alpha1. Please help to double check if there is any other file using the old version. Thanks.

test/e2e/traceflow_test.go has been updated in #5667

Looks like @antoninbas also left a comment here #5667 (review) to make version update as a separate PR.

I think you can make all version update related changes here and update the title and description.

@Atish-iaf
Use Traceflow API v1beta1
f87b4ca 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
@Atish-iaf Atish-iaf force-pushed the update-traceflow-api-in-antctl branch from d5f88aa to f87b4ca Compare November 14, 2023 08:03
@Atish-iaf Atish-iaf changed the title Use Traceflow API v1beta1 in antctl traceflow Use Traceflow API v1beta1 Nov 14, 2023
luolanzone
luolanzone approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Atish-iaf
Copy link
Contributor Author

@luolanzone Does it require to be backported to release-1.13 ? as traceflow API was promoted to v1beta1 in release-1.13 but these code changes were missed.

@luolanzone
Copy link
Contributor

@luolanzone Does it require to be backported to release-1.13 ? as traceflow API was promoted to v1beta1 in release-1.13 but these code changes were missed.

It should has no function impact but I feel we'd better to backport it to keep version consistent. @tnqn @antoninbas any suggestion?

@Atish-iaf
Copy link
Contributor Author

/test-e2e

@antoninbas
Copy link
Contributor

@luolanzone I think if we group all missing v1alpha1 -> v1beta1 changes in one PR, then we can backport it if we want. I don't think this impacts users, given that we agreed a while back that Traceflows were a special type of CR (short-lived).

@rajnkamr
Copy link
Contributor

@antoninbas @tnqn , We need traceflow v1alpha1 -> v1beta1 migration changes for req wrt #5667, hence are targeting early merge for #5689 , could you help with the further review and merge

@antoninbas antoninbas added action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. labels Nov 15, 2023
@antoninbas
Copy link
Contributor

/skip-conformance
/skip-network-policy

@antoninbas
Copy link
Contributor

/skip-networkpolicy

@antoninbas antoninbas merged commit aa1c6b0 into antrea-io:main Nov 15, 2023
49 of 56 checks passed
@antoninbas
Copy link
Contributor

@Atish-iaf please take care of backporting as needed

@Atish-iaf Atish-iaf mentioned this pull request Nov 16, 2023
Merged
@Atish-iaf Atish-iaf mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luolanzone luolanzone luolanzone approved these changes

@antoninbas antoninbas antoninbas approved these changes

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. area/component/antctl Issues or PRs releated to the command line interface component area/ops/traceflow Issues or PRs related to the Traceflow feature kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
Antrea v1.15 release
Development

Successfully merging this pull request may close these issues.

Use Traceflow API v1beta1 in antctl traceflow
4 participants
@Atish-iaf @luolanzone @antoninbas @rajnkamr