Rename service related fields in Connection struct #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuntanghsu please try to keep the commit title short, ideally git / Github should not have to truncate it see https://cbea.ms/git-commit/ (link is from our CONTRIBUTING doc) |
we rename DestinationServiceAddress and DestinationServicePort in Connection struct as they actually represent the value of OriginalDestinationAddress and OriginalDestinationPort. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
changed the title
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up PR for #5573 .
In this PR, we rename
DestinationServiceAddressandDestinationServicePortfor Connection struct as they actually represent the value ofOriginalDestinationAddressandOriginalDestinationPort.If these two values belong to a service traffic, we will fill them into
destinationClusterIPv4/destinationClusterIPv6anddestinationServicePortbefore we export them from the Flow Exporter.