Record an event when Egress IP assignment changes #5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
d23db4b to
ee8a7e4
Compare
rajnkamr
added
the
area/transit/egress
jainpulkit22
force-pushed
the
egress-api-visibility
branch
2 times, most recently
from
408448f to
f2cb840
Compare
rajnkamr
reviewed
Dec 12, 2023
tnqn
reviewed
Dec 12, 2023
luolanzone
reviewed
Dec 13, 2023
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
f2cb840 to
a4e8104
Compare
tnqn
reviewed
Dec 13, 2023
jainpulkit22
force-pushed
the
egress-api-visibility
branch
5 times, most recently
from
f20c9b2 to
169f508
Compare
tnqn
reviewed
Dec 21, 2023
jainpulkit22
force-pushed
the
egress-api-visibility
branch
3 times, most recently
from
8320b84 to
d28a2d1
Compare
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
d28a2d1 to
fca9c90
Compare
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
fca9c90 to
b11d5c4
Compare
tnqn
reviewed
Dec 28, 2023
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
b11d5c4 to
fe760bc
Compare
jainpulkit22
changed the title
jainpulkit22
force-pushed
the
egress-api-visibility
branch
2 times, most recently
from
6720c1a to
1a7e460
Compare
jainpulkit22
requested review from
tnqn and
luolanzone
and removed request for
luolanzone
tnqn
reviewed
Jan 2, 2024
There was a problem hiding this comment.
It should add patch and update permission of events, otherwise it can't correctly record events in some case:
I0102 05:49:41.364352 1 event.go:294] "Event occurred" object="egress-pirate-pods" fieldPath="" kind="Egress" apiVersion="crd.antrea.io/v1beta1" type="Normal" reason="IPAssigned" message="Assigned Egress egress-pirate-pods with IP 172.18.0.10 on Node kind-worker"
E0102 05:49:41.366451 1 event.go:267] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"egress-pirate-pods.17a671a773e1d992", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"1122", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"Egress", Namespace:"", Name:"egress-pirate-pods", UID:"9a3312c6-c90f-446d-b112-d6af3b43d330", APIVersion:"crd.antrea.io/v1beta1", ResourceVersion:"1266", FieldPath:""}, Reason:"IPAssigned", Message:"Assigned Egress egress-pirate-pods with IP 172.18.0.10 on Node kind-worker", Source:v1.EventSource{Component:"AntreaAgentEgressController", Host:""}, FirstTimestamp:time.Date(2024, time.January, 2, 5, 47, 53, 0, time.Local), LastTimestamp:time.Date(2024, time.January, 2, 5, 49, 41, 364053810, time.Local), Count:2, Type:"Normal", EventTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events "egress-pirate-pods.17a671a773e1d992" is forbidden: User "system:serviceaccount:kube-system:antrea-agent" cannot patch resource "events" in API group "" in the namespace "default"' (will not retry!)
1a7e460 to
c2d24ad
Compare
Record an event when EgressIP is assigned to the Node interface or when it is unassigned from the Node interface. Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22
force-pushed
the
egress-api-visibility
branch
from
c2d24ad to
c07d213
Compare
|
/test-all |
|
/skip-conformance which failed due to a service IP overlapping with server IP |
|
/skip-conformance |
tnqn
added
the
action/release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4614.
Record event when EgressIP is assigned to the Node interface.