Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CNI plugins from v1.3.0 to v1.4.0 #5813

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Dec 19, 2023

CNI plugin released v1.4.0 with golang 1.21, we can fix more CVEs with a newer golang version.

No need to maintain our own built CNI binary in short term. Fixes #5763
We probably can try to raise an issue first in the CNI binary repo to ask for a new release in the future if a similar case happened.

Signed-off-by: Lan Luo <luola@vmware.com>
@antoninbas
Copy link
Contributor

/test-all
/test-windows-all

@antoninbas
Copy link
Contributor

@luolanzone I forgot that you will need to trigger a build of antrea/base-windows first, before we can merge this
You can do it yourself by running this workflow (https://github.com/antrea-io/antrea/actions/workflows/docker_update_base_windows.yml) and use your fork & branch as input parameters.

@luolanzone
Copy link
Contributor Author

@luolanzone I forgot that you will need to trigger a build of antrea/base-windows first, before we can merge this You can do it yourself by running this workflow (https://github.com/antrea-io/antrea/actions/workflows/docker_update_base_windows.yml) and use your fork & branch as input parameters.

Hi, @antoninbas thanks for reminder, I triggered the workflow, but looks like it has a problem to get the Windows cni file from github, I tried in a linux host, download works fine. I will rerun the workflow later.
Meanwhile, I was not sure if "git/https" should be in the repo parameter, it take me a little time to figure out what's the format should be. So I submitted a PR #5816 to update the workflow description, please help to review. Thanks.

@luolanzone luolanzone added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@tnqn
Copy link
Member

tnqn commented Dec 21, 2023

@luolanzone is the mergeable?

@luolanzone
Copy link
Contributor Author

luolanzone commented Dec 21, 2023

Hi, @tnqn it's not ready to merge, the Windows base image workflow still failed, Not sure why the curl command on github Windows runner to get the cni binary is so unstable. I had rerun a few times but no luck yet. https://github.com/antrea-io/antrea/actions/runs/7269844266. I will update here if the base image is ready.

@luolanzone
Copy link
Contributor Author

@tnqn , this PR is merge-able now. The base images are updated via this manual workflow build https://github.com/antrea-io/antrea/actions/runs/7354252963/job/20021229050. There is something wrong with curl command, after I replaced it with Windows build-in command 'Invoke-WebRequest', the build can pass. The root cause of curl failure is still not clear yet. I will submit a separate PR to update the Dockerfile to use 'Invoke-WebRequest' to build base Windows images considering it's not used frequently.

@antoninbas antoninbas merged commit 7f2914a into antrea-io:main Jan 3, 2024
47 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain CNI plugin with latest Golang version in Antrea
3 participants