Add missing space for kubelet args in Prepare-Node.ps1 #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no space before `--cert-dir`. As a result, the command-line arg had no effect and kubelet could not start. Fixes antrea-io#5857 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
requested review from
wenyingd,
rajnkamr,
XinShuYang,
NamanAg30,
Atish-iaf and
luolanzone
|
@rajnkamr @XinShuYang I am curious about why this was not detected by our Windows CI? |
antoninbas
added
action/backport
This script is mainly used during the testbed deployment, and our CI jobs never test it. Although I validated this script manually during the review of #5071, the issue could be introduced in the last few rounds of code update. |
|
/skip-all |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no space before
--cert-dir. As a result, the command-line arg had no effect and kubelet could not start.Fixes #5857