-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated v1alpha2 ClusterGroups #6049
Remove deprecated v1alpha2 ClusterGroups #6049
Conversation
689c7b8
to
3527855
Compare
3527855
to
8ea6b40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkg/apis/crd/v1alpha2/webhook.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but I cannot figure what we are using this code for?
In particular, I cannot find any call to the RegisterWebhook
function below.
@tnqn do you know if this is some unused legacy code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question when it's pushed: #775 (comment) and Su explained it. I think it was supposed to be called from another probject that imports the package, and it may be no longer needed? Besides, controller-runtime has deprecated this pattern: kubernetes-sigs/controller-runtime#2639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luolanzone I see that you deleted the file. Maybe we should do it in a separate PR to be on the safe side (and because it's unrelated to this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I will create another PR to remove this file.
3675d42
to
d985f57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a conflict |
Signed-off-by: Lan Luo <luola@vmware.com>
d985f57
to
646d556
Compare
Conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
Signed-off-by: Lan Luo <luola@vmware.com>
No description provided.