Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows binaries compiling job to Github action #606

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Add windows binaries compiling job to Github action #606

merged 1 commit into from
Apr 12, 2020

Conversation

ruicao93
Copy link
Contributor

@ruicao93 ruicao93 commented Apr 9, 2020 •
edited
Loading

  • Compile following packages for windows:
      - antrea-cni
      - antrea-agent
  • Add compile windows binaries job in Github action

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@wenyingd wenyingd mentioned this pull request Apr 9, 2020
Closed
21 tasks
@ruicao93
Copy link
Contributor Author

ruicao93 commented Apr 9, 2020

/test-all

@ruicao93 ruicao93 changed the title Add cross compile for windows binaries Add cross compile support for windows binaries Apr 9, 2020
@ruicao93
Copy link
Contributor Author

ruicao93 commented Apr 9, 2020

/test-all

@ruicao93 ruicao93 closed this Apr 9, 2020
@ruicao93 ruicao93 reopened this Apr 9, 2020
@ruicao93
Copy link
Contributor Author

ruicao93 commented Apr 9, 2020

/test-all

antoninbas
antoninbas reviewed Apr 9, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ruicao93 ruicao93 force-pushed the windows_compile branch 6 times, most recently from 4d61431 to b7f4522 Compare April 10, 2020 01:33
@ruicao93
Copy link
Contributor Author

/skip-all

antoninbas
antoninbas reviewed Apr 10, 2020
View reviewed changes
Makefile Show resolved Hide resolved
tnqn
tnqn reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the decscription:
Add compile windows binaries job in Github action =>
Add windows binaries compiling job to Github action

Makefile Show resolved Hide resolved
antoninbas
antoninbas approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruicao93
Add windows binaries compiling job to Github action
4bca03e 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93
Copy link
Contributor Author

/skip-all

@ruicao93
Copy link
Contributor Author

Maybe update the decscription:
Add compile windows binaries job in Github action =>
Add windows binaries compiling job to Github action

Thanks Quan. Update the description.

@ruicao93 ruicao93 changed the title Add cross compile support for windows binaries Add windows binaries compiling job to Github action Apr 12, 2020
@ruicao93 ruicao93 merged commit fe1a38f into antrea-io:windows Apr 12, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request May 27, 2020
@ruicao93
Add windows binaries compiling job to Github action (antrea-io#606)
7c50d77 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
ruicao93 added a commit that referenced this pull request May 27, 2020
@ruicao93
Add windows binaries compiling job to Github action (#606)
c818962 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman pushed a commit to McCodeman/antrea that referenced this pull request Jun 2, 2020
@ruicao93 @McCodeman
Add windows binaries compiling job to Github action (antrea-io#606)
fa7e3dd 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman pushed a commit that referenced this pull request Jun 2, 2020
@ruicao93 @McCodeman
Add windows binaries compiling job to Github action (#606)
031c34d 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93 ruicao93 deleted the windows_compile branch July 8, 2020 03:54
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@ruicao93 @GraysonWu
Add windows binaries compiling job to Github action (antrea-io#606)
0c75368 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 23, 2020
@ruicao93 @GraysonWu
Add windows binaries compiling job to Github action (antrea-io#606)
80a741a 
- Compile following packages for windows:
  - antrea-cni
  - antrea-agent
- Add compile windows binaries job in Github action.

Signed-off-by: Rui Cao <rcao@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn left review comments

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruicao93 @antrea-bot @antoninbas @tnqn @vmwclabot