Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5988: Disable cgo for all Antrea binaries (#5988) #6126

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #5988 on release-1.15.

#5988: Disable cgo for all Antrea binaries (#5988)

For details on the cherry pick process, see the cherry pick requests page.

* Disable cgo for all Antrea binaries

Instead of selectively disabling cgo for some binaries (e.g., release
assets), we now unconditionally disable cgo for all binaries, even those
that only run inside the container image for which they were built
(e.g., antrea-controller). After some analysis, there seems to be no
downside in doing this. We also get some benefits such as reduced build
time for the default make command.

Fixes antrea-io#5724

* Revert "Add git to antrea-build image for UBI build (antrea-io#5727)"

This reverts commit 2f8441b.

* Revert "Fix antrea-ubi image build (antrea-io#5723)"

This reverts commit 2afab06.

---------

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Mar 20, 2024
@luolanzone
Copy link
Contributor Author

/test-vm-e2e

@tnqn
Copy link
Member

tnqn commented Mar 20, 2024

#6008 is needed to pass the test

Fix the TestVMAgent/testExternalNodeSupportBundleCollection test.
The test case was not updated correctly after antrea-io#5538 was merged.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@luolanzone
Copy link
Contributor Author

/test-vm-e2e

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Mar 21, 2024

/skip-all

1 similar comment
@tnqn
Copy link
Member

tnqn commented Mar 21, 2024

/skip-all

@tnqn tnqn merged commit 3df1707 into antrea-io:release-1.15 Mar 21, 2024
45 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants