-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Support set DNS from runtime config in CNI request #642
Conversation
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
/test-all |
/test-all |
/test-e2e |
1 similar comment
/test-e2e |
ddedeb3
to
eedb593
Compare
/test-all |
/test-e2e |
1 similar comment
/test-e2e |
/test-all |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
/test-all |
3 similar comments
/test-all |
/test-all |
/test-all |
/test-all |
/test-all |
/test-networkpolicy |
…io#642) On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
…io#642) On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
…io#642) On windows platform, DNS config is passed by runtime config conained in CNI request. This PR support set windows container DNS from the DNS config specified in runtime config. DNS Capability is needed to be set in CNI config file to enable DNS config can be passed in runtime config. Signed-off-by: Rui Cao <rcao@vmware.com>
On windows platform, DNS config is passed by runtime config of CNI request.
This PR support set DNS config from DNS specified in runtime config.
DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.