Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Support set DNS from runtime config in CNI request #642

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

ruicao93
Copy link
Contributor

@ruicao93 ruicao93 commented Apr 21, 2020

On windows platform, DNS config is passed by runtime config of CNI request.
This PR support set DNS config from DNS specified in runtime config.
DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@wenyingd wenyingd mentioned this pull request Apr 21, 2020
21 tasks
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93 ruicao93 requested review from wenyingd and tnqn April 21, 2020 08:55
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/test-e2e

1 similar comment
@ruicao93
Copy link
Contributor Author

/test-e2e

@ruicao93 ruicao93 force-pushed the windows_dns branch 2 times, most recently from ddedeb3 to eedb593 Compare April 22, 2020 04:31
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/test-e2e

1 similar comment
@ruicao93
Copy link
Contributor Author

/test-e2e

@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/test-all

Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93
Copy link
Contributor Author

/test-all

3 similar comments
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/test-all

@wenyingd
Copy link
Contributor

/test-all

@wenyingd
Copy link
Contributor

/test-all

@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/test-networkpolicy

@ruicao93 ruicao93 merged commit 30e4007 into antrea-io:windows Apr 27, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request May 27, 2020
…io#642)

On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
ruicao93 added a commit that referenced this pull request May 27, 2020
On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman pushed a commit to McCodeman/antrea that referenced this pull request Jun 2, 2020
…io#642)

On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
McCodeman pushed a commit that referenced this pull request Jun 2, 2020
On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93 ruicao93 deleted the windows_dns branch July 8, 2020 03:55
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
…io#642)

On windows platform, DNS config is passed by runtime config conained in CNI request.
This PR support set windows container DNS from the DNS config specified in runtime
config. DNS Capability is needed to be set in CNI config file to enable DNS config
can be passed in runtime config.

Signed-off-by: Rui Cao <rcao@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants