Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Antrea Windows requirements for containerd and Kubernetes #6462

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

XinShuYang
Copy link
Contributor

@XinShuYang XinShuYang commented Jun 19, 2024

  • Add detailed containerd version requirements for various Kubernetes versions.
  • Upgrade agnhost image for Windows2022 compatibility.

@XinShuYang
Copy link
Contributor Author

/test-all

@XinShuYang XinShuYang marked this pull request as ready for review July 2, 2024 02:05
wenyingd
wenyingd previously approved these changes Jul 2, 2024
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinShuYang
Copy link
Contributor Author

/test-windows-all

Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

docs/windows.md Outdated
| 1.29 | 1.7.11+, 1.6.27+ |
| 1.30 | 1.7.13+, 1.6.28+ |

Note: Starting from Antrea v2.1, Antrea Windows image is built based on the hpc image, containerd version 1.6.18 or higher is required because versions earlier than 1.6.18 do not support importing HPC images on Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: Starting from Antrea v2.1, Antrea Windows image is built based on the hpc image, containerd version 1.6.18 or higher is required because versions earlier than 1.6.18 do not support importing HPC images on Windows.
Note: Starting from Antrea v2.1, Antrea Windows image is built based on the HPC (Host Process Containers) image,
containerd version 1.6.18 or higher is required because versions earlier than 1.6.18 do not support
importing HPC images on Windows.

Please make the line length around 80-100 chars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@luolanzone luolanzone requested a review from tnqn July 10, 2024 03:31
* Add detailed containerd version requirements for various Kubernetes versions.
* Upgrade agnhost image for Windows2022 compatibility.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

test-all and test-windows-all passed. The latest changes is just doc update.

@tnqn
Copy link
Member

tnqn commented Jul 10, 2024

/skip-all

@tnqn tnqn merged commit 67cd120 into antrea-io:main Jul 10, 2024
53 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants