Fix NodeLatencyMonitor not starting #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeLatencyMonitor was not starting (more precisely, the monitorLoop method was never called). This is because NewNodeLatencyMonitor was called *after* starting the informer factory. This means that the informer created in NewNodeLatencyMonitor was never started, and that WaitForNamedCacheSync was blocking indefinitely. With this change, we ensure that NewNodeLatencyMonitor is called *before* starting the informer factory. The Run method is still called at the end of Agent "initialization", once the datapath has been configured. Note that it is not clear that WaitForNamedCacheSync is really needed for the NodeLatencyMonitor. However, it is probably fine to use the same "pattern" as for our other controllers. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
|
@IRONICBo FYI |
luolanzone
approved these changes
Jul 25, 2024
|
@antoninbas thanks for testing and ensuring it works, otherwise it would be awkward to encounter the issue after release. We do need an e2e test to validate it if there isn't one. @IRONICBo did you make last minute change to it after testing done? I'm also curious how did it work before. |
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeLatencyMonitor was not starting (more precisely, the monitorLoop method was never called). This is because NewNodeLatencyMonitor was called after starting the informer factory. This means that the informer created in NewNodeLatencyMonitor was never started, and that WaitForNamedCacheSync was blocking indefinitely.
With this change, we ensure that NewNodeLatencyMonitor is called before starting the informer factory. The Run method is still called at the end of Agent "initialization", once the datapath has been configured.
Note that it is not clear that WaitForNamedCacheSync is really needed for the NodeLatencyMonitor. However, it is probably fine to use the same "pattern" as for our other controllers.