-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ubuntu to 24.04 (Noble) #6575
Upgrade Ubuntu to 24.04 (Noble) #6575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit.
@XinShuYang could you check the base VM OS used in CI pipeline? We may consider to upgrade as well when doing DC migration. |
Our CI cluster contains both 20.04 and 22.04 VMs. For the migrated cluster, We are deploying 22.04 VM based on the verified image. For CAPV compatibility, I prefer upgrading VM OS in CI after the CAPV 24.04 image is released in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere#kubernetes-versions-with-published-ovas . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the typo is fixed
e1dedaa
to
b4d6823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I found L7NetworkPolicy didn't run due to a bug in test script, created #6586 and we should rebase on it to validate if suricata 7.0 works.
b4d6823
to
c2347d4
Compare
@tnqn Nice catch, I have merged your PR and rebased |
/test-all |
Given that I have been informed that Suricata 6 is now end of life (https://forum.suricata.io/t/suricata-6-is-now-end-of-life-eol/4790), I will use a separate patch to upgrade to Suricata 7. We will merge it first, and backport it to supported Antrea versions. |
Depends on #6589 |
c2347d4
to
bda4554
Compare
@tnqn PTAL |
/test-all |
/test-kind-ipv6-all |
/test-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrade to ubuntu:24.04 in most places (except for a few build / test images which will be updated later on). In particular ubuntu:24.04 is now the base image for antrea/antrea-agent-ubuntu and antrea/controller-ubuntu. In order for our current version of OVS (2.17.7) to build correctly on Ubuntu 24.04, some "recent" patches have to be applied manually. After this change, the antrea/antrea-agent-ubuntu image is slightly bigger (344MB -> 372MB uncompressed), and the size increase seems to be driven by some systemd libraries. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
bda4554
to
45c4c38
Compare
/test-all |
/test-e2e |
1 similar comment
/test-e2e |
The Python3 version has changed between Ubuntu 22.04 and 24.04 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
/test-all |
@tnqn @luolanzone can I get a new approval for this, I had to make a small change (see second commit)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrade to ubuntu:24.04 in most places (except for a few build / test images which will be updated later on). In particular ubuntu:24.04 is now the base image for antrea/antrea-agent-ubuntu and antrea/controller-ubuntu. In order for our current version of OVS (2.17.7) to build correctly on Ubuntu 24.04, some "recent" patches have to be applied manually. After this change, the antrea/antrea-agent-ubuntu image is slightly bigger (344MB -> 372MB uncompressed), and the size increase seems to be driven by some systemd libraries. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Upgrade to ubuntu:24.04 in most places (except for a few build / test
images which will be updated later on). In particular ubuntu:24.04 is
now the base image for antrea/antrea-agent-ubuntu and
antrea/controller-ubuntu.
In order for our current version of OVS (2.17.7) to build correctly on
Ubuntu 24.04, some "recent" patches have to be applied manually.
After this change, the antrea/antrea-agent-ubuntu image is slightly
bigger (344MB -> 372MB uncompressed), and the size increase seems to be
driven by some systemd libraries.