Add "antctl get bgppeers" agent command #6689
Conversation
Atish-iaf
added
area/component/antctl
Atish-iaf
force-pushed
the
antctl-get-bgppeers
branch
from
c6670c5
to
a965cc5
Compare
| if c.bgpPolicyState == nil { | ||
| return nil, fmt.Errorf("failed to get bgp peers: there is no effective bgp policy applied to the Node") | ||
| } | ||
| peers, err := c.bgpPolicyState.bgpServer.GetPeers(context.TODO()) |
There was a problem hiding this comment.
holding a read lock while calling this function may be bit overkill. In the case of gobgp at least, all these operations are asynchronous (so there can be some delay, hence the context parameter) and all the server functions can be called concurrently as far as I know.
so the following would probably be correct:
getBgpServer := func() bgp.Interface {
c.bgpPolicyStateMutex.RLock()
defer c.bgpPolicyStateMutex.RUnlock()
if c.bgpPolicyState == nil {
return nil
}
return c.bgpPolicyState.bgpServer
}
bgpServer := getBgpServer()
if bgpServer == nil {
// return error
}
peers, err := bgpServer.GetPeers(ctx)This way we don't hold the read lock for a potentially expensive async operation.
That means that we have to guarantee that all bgp.Interface implementations (at the moment we only have gobgp) support concurrent function calls. Probably worth double checking that this assumption holds for gobgp, but it seems to me that all API calls get serialized to a channel.
rajnkamr
added
the
kind/documentation
luolanzone
added
the
action/release-note
Atish-iaf
removed
the
kind/documentation
Atish-iaf
force-pushed
the
antctl-get-bgppeers
branch
from
a965cc5
to
56c2249
Compare
Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Atish-iaf
force-pushed
the
antctl-get-bgppeers
branch
from
56c2249
to
7d1f69c
Compare
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
/test-all |
|
/test-conformance |
|
/test-kind-conformance |
Add
antctl get bgppeersagent command to print current status of all BGP peersof effective BGP policy applied on the local Node.
For #6209