Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlowAggregator] Add templateRefreshTimeout configuration #6699

Conversation

antoninbas
Copy link
Contributor

Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector.

We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both.

@antoninbas antoninbas added this to the Antrea v2.2 release milestone Sep 27, 2024
@antoninbas antoninbas added area/flow-visibility/aggregator Issues or PRs related to Flow Aggregator action/release-note Indicates a PR that should be included in release notes. labels Sep 27, 2024
Can be used to configure the template retransmission interval when using
the UDP protocol to export records to an IPFIX collector.

We also ensure that the default value is 600s, not 1800s, which is the
value specified in RFC 6728. We do the same thing for the Agent
Exporter, but this time by letting the go-ipfix library decide the value
(we set it to 0 in ExporterInput to request the default). This is
important because the templateRefreshTimeout config in the Agent's
exporter and the templateTTL in teh Aggregator's collector must "match"
(templateTTL = 3 x templateRefreshTimeout), and so it is better to let
go-ipfix pick the right values for both.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas force-pushed the fa-add-templateRefreshTimeout-configuration branch from 346e01d to f57b7c0 Compare October 1, 2024 20:07
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There's a typo in the commit message
"templateTTL in teh Aggregator's" -> "templateTTL in the Aggregator's"

@antoninbas
Copy link
Contributor Author

Thanks @heanlan, I can fix it when I squash and merge.

@antoninbas
Copy link
Contributor Author

/test-kind-all

@antoninbas
Copy link
Contributor Author

/test-kind-all

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit 51c5107 into antrea-io:main Oct 11, 2024
53 of 63 checks passed
@antoninbas antoninbas deleted the fa-add-templateRefreshTimeout-configuration branch October 11, 2024 22:19
hangyan pushed a commit to hangyan/antrea that referenced this pull request Oct 29, 2024
…6699)

Can be used to configure the template retransmission interval when using
the UDP protocol to export records to an IPFIX collector.

We also ensure that the default value is 600s, not 1800s, which is the
value specified in RFC 6728. We do the same thing for the Agent
Exporter, but this time by letting the go-ipfix library decide the value
(we set it to 0 in ExporterInput to request the default). This is
important because the templateRefreshTimeout config in the Agent's
exporter and the templateTTL in teh Aggregator's collector must "match"
(templateTTL = 3 x templateRefreshTimeout), and so it is better to let
go-ipfix pick the right values for both.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/flow-visibility/aggregator Issues or PRs related to Flow Aggregator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants