Block on stopCh in Run method of controllerMonitor #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Run method of controllers usually never returns until the stop channel is closed. The controllerMonitor seems to be the exception, as it returns after "initialization", despite the Run method being invoked in a separate goroutine. This leads to a confusing message in the Antrea Controller logs, informing us that AntreaControllerMonitor is shutting down. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
tnqn
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Run method of controllers usually never returns until the stop channel is closed. The controllerMonitor seems to be the exception, as it returns after "initialization", despite the Run method being invoked in a separate goroutine. This leads to a confusing message in the Antrea Controller logs, informing us that AntreaControllerMonitor is shutting down.