Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default tunnel type to Geneve #894

Closed
wants to merge 3 commits into from
Closed

Conversation

abhiraut
Copy link
Contributor

@abhiraut abhiraut commented Jul 1, 2020

Set default tunnel type to Geneve for Antrea and run netpol tests with VXLAN tunnel type. Netpol tests will be switched back to
default tunnel type once failure in running netpol test suite in Kind clusters is root caused.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 1, 2020

/test-networkpolicy

@abhiraut abhiraut changed the title Test: Set default tunnel type to Geneve Set default tunnel type to Geneve Jul 2, 2020
@abhiraut abhiraut requested review from antoninbas, jianjuns and tnqn July 2, 2020 02:00
hack/generate-manifest.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the formatting issue pointed out by Quan

@abhiraut abhiraut requested review from antoninbas and tnqn July 2, 2020 02:23
antoninbas
antoninbas previously approved these changes Jul 2, 2020
@tnqn
Copy link
Member

tnqn commented Jul 2, 2020

@wenyingd reminded me that windows ovsext is similar to netdev, and it looks like we don't have windows-networkpolicy CI test yet, can we make sure the change won't break windows networkpolicy before merging it?
cc @jianjuns @antoninbas @ruicao93 too.

@wenyingd
Copy link
Contributor

wenyingd commented Jul 2, 2020

/test-windows-networkpolicy

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 2, 2020

/test-all

jianjuns
jianjuns previously approved these changes Jul 2, 2020
@jianjuns
Copy link
Contributor

jianjuns commented Jul 2, 2020

@wenyingd reminded me that windows ovsext is similar to netdev, and it looks like we don't have windows-networkpolicy CI test yet, can we make sure the change won't break windows networkpolicy before merging it?
cc @jianjuns @antoninbas @ruicao93 too.

/test-windows-networkpolicy is not Windows networkpolicy tests?

@wenyingd
Copy link
Contributor

wenyingd commented Jul 2, 2020

@wenyingd reminded me that windows ovsext is similar to netdev, and it looks like we don't have windows-networkpolicy CI test yet, can we make sure the change won't break windows networkpolicy before merging it?
cc @jianjuns @antoninbas @ruicao93 too.

/test-windows-networkpolicy is not Windows networkpolicy tests?

It is a CI test for Windows networkpolicy cases. But it is not enabled by default now. I have triggered a job for test-windows-networkpolicy, meanwhile, Rui is running tests on the local testbed. Will update the result after the tests complete.

@tnqn
Copy link
Member

tnqn commented Jul 2, 2020

@wenyingd reminded me that windows ovsext is similar to netdev, and it looks like we don't have windows-networkpolicy CI test yet, can we make sure the change won't break windows networkpolicy before merging it?
cc @jianjuns @antoninbas @ruicao93 too.

/test-windows-networkpolicy is not Windows networkpolicy tests?

I didn't know we already have it, it's triggered manually by @wenyingd, then let's wait for the result.
@lzhecheng could we make it run automatically with "test-all", and could we only trigger tests when "/xxxx" is the beginning of a line, otherwise it's easy to trigger it by no intention when talking about it.

@wenyingd
Copy link
Contributor

wenyingd commented Jul 2, 2020

Both of the CI job (59) I triggered manually and Rui's local test have passed.

@wenyingd
Copy link
Contributor

wenyingd commented Jul 2, 2020

/test-windows-conformance

@tnqn
Copy link
Member

tnqn commented Jul 2, 2020

/test-e2e

2 similar comments
@jianjuns
Copy link
Contributor

jianjuns commented Jul 2, 2020

/test-e2e

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 2, 2020

/test-e2e

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 2, 2020

rebased

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 2, 2020

/test-all

antoninbas
antoninbas previously approved these changes Jul 2, 2020
@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 2, 2020

/test-all

rebased

@abhiraut abhiraut requested a review from antoninbas July 2, 2020 21:11
@lzhecheng
Copy link
Contributor

/test-windows-conformance

@antoninbas
Copy link
Contributor

Superseded by #903

@antoninbas antoninbas closed this Jul 3, 2020
@abhiraut abhiraut deleted the geneve branch July 23, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants