Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print CNP priority on kubectl get cnp cnpName output #906

Merged
merged 3 commits into from
Jul 3, 2020
Merged

Print CNP priority on kubectl get cnp cnpName output #906

merged 3 commits into from
Jul 3, 2020

Conversation

abhiraut
Copy link
Contributor

@abhiraut abhiraut commented Jul 3, 2020 •
edited
Loading

Before this change:
kubectl get cnp cnp0
NAME AGE
cnp0 49m

After this change:
kubectl get cnp cnp0
NAME PRIORITY AGE
cnp0 10 49m

@abhiraut abhiraut requested review from antoninbas, tnqn and jianjuns July 3, 2020 00:55
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

antoninbas
antoninbas previously approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jianjuns
jianjuns reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make manifest to generate new deployment yamls?

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 3, 2020

make manifest to generate new deployment yamls?

my bad

@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 3, 2020

/test-all

@abhiraut abhiraut requested review from antoninbas and jianjuns July 3, 2020 01:30
@abhiraut
Copy link
Contributor Author

abhiraut commented Jul 3, 2020

/test-all

tnqn
tnqn approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/test-e2e

@antoninbas
Copy link
Contributor

/test-e2e

@tnqn
Copy link
Member

tnqn commented Jul 3, 2020 •
edited
Loading

The previous e2e test failure is because of traceflow intra node case, the tracing request is sent right after creating networkpolicies, leaving no time for them to be enforced. @lzhecheng is working on adding a polling networkpolicy status (by querying antctl on target node) to fix it.

@jianjuns jianjuns merged commit bfe465b into antrea-io:master Jul 3, 2020
@antoninbas antoninbas mentioned this pull request Jul 3, 2020
Merged
@abhiraut abhiraut deleted the cnp-prio-printer branch July 23, 2020 23:45
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@abhiraut @GraysonWu
Print CNP priority on kubectl get cnp cnpName output (antrea-io#906)
44ced4d 
* Print CNP priority on kubectl get cnp cnpName output

* Make manifest

* Add Age to Printer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@tnqn tnqn tnqn approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abhiraut @antrea-bot @antoninbas @tnqn @jianjuns @vmwclabot