feat: Add Helm support for Nephe #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachjainrahul
force-pushed
the
helm
branch
2 times, most recently
from
9c682ca
to
c088436
Compare
antoninbas
reviewed
Mar 15, 2023
reachjainrahul
force-pushed
the
helm
branch
2 times, most recently
from
47fca9a
to
4012641
Compare
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 56.05% 56.00% -0.05%
==========================================
Files 52 52
Lines 8756 8744 -12
==========================================
- Hits 4908 4897 -11
+ Misses 3364 3362 -2
- Partials 484 485 +1
|
|
/nephe-test-e2e-kind |
|
/nephe-test-e2e-aws |
We decided to put CRD in sub-charts for 2 reasons. We wanted to install CRDs before any config and secondly we wanted CRD to support templates which is required for webhooks. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-2-separate-charts We havent supported generation of manifests for helm automatically. Its a manual process to copy the yamls in the helm chart directory. Also CI is not updated to use helm chart way of installation. Signed-off-by: Rahul Jain <rahulj@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.