Update Grafana Panel Plugins #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamtalen
approved these changes
Sep 27, 2022
|
/theia-test-e2e |
This PR does the following two things: When testing with snowflake datasource plugin, we found it will automatically convert all fields name to upper case, which will lead to string matching failure in our sankey-panel plugin and chord-panel plugin, as we are doing case sensitive string matching. As a work around, we do the following change to both sankey and chord plugins: when search for fields with names in data frame, do case insenstive string matching. When testing with snowflake datasource plugin, we found for a field with type String, when the value is Null, it will not convert a Null to ''. So we change our chord panel plugin to also check for Null value, to be compatible with different datasources. Signed-off-by: heanlan <hanlan@vmware.com>
heanlan
force-pushed
the
update-chord-plugin
branch
from
7b37b59
to
bc4d50c
Compare
heanlan
changed the title
|
@dreamtalen @yuntanghsu thanks for the quick review. I just merged my other changes of plugins in #117 into this PR. I previously came up with a "workaround" on Grafana dashboard, with which I thought the changes are no longer needed, so I closed that PR. Just found the workaround still not work, so I added the changes back. Please help take another look when you have time. Still a small PR. |
heanlan
added a commit
to heanlan/theia-1
that referenced
this pull request
Sep 28, 2022
This PR adds 4 Grafana dashboards with snowflake as the datasource: Home Dashboard, Flow Records Dashboard, Pod-to-Pod Flows Dashboard, and Network-Policy Flows Dashboard. These dashboards are basically the same with ClickHouse dashboards in their contents, differ in the query syntax. Currently, the snowflake dashboards are without the ad-hoc filters, as the datasource plugin does not offer the the support. We can revisit it later if we decide to work with Grafana in the long-term. In the deployment instruction, we suggest users deploy Grafana with docker, so they do not need to install Grafana locally, and it makes the custom plugins installation simple. This PR should be merged after antrea-io#112 and antrea-io#118. The documentation shall also be merged into the README.md introduced in antrea-io#112 Signed-off-by: heanlan <hanlan@vmware.com>
yanjunz97
approved these changes
Sep 28, 2022
heanlan
added a commit
to heanlan/theia-1
that referenced
this pull request
Oct 5, 2022
This PR adds 4 Grafana dashboards with snowflake as the datasource: Home Dashboard, Flow Records Dashboard, Pod-to-Pod Flows Dashboard, and Network-Policy Flows Dashboard. These dashboards are basically the same with ClickHouse dashboards in their contents, differ in the query syntax. Currently, the snowflake dashboards are without the ad-hoc filters, as the datasource plugin does not offer the the support. We can revisit it later if we decide to work with Grafana in the long-term. In the deployment instruction, we suggest users deploy Grafana with docker, so they do not need to install Grafana locally, and it makes the custom plugins installation simple. This PR should be merged after antrea-io#112 and antrea-io#118. The documentation shall also be merged into the README.md introduced in antrea-io#112 Signed-off-by: heanlan <hanlan@vmware.com>
heanlan
added a commit
to heanlan/theia-1
that referenced
this pull request
Oct 10, 2022
This PR adds 4 Grafana dashboards with snowflake as the datasource: Home Dashboard, Flow Records Dashboard, Pod-to-Pod Flows Dashboard, and Network-Policy Flows Dashboard. These dashboards are basically the same with ClickHouse dashboards in their contents, differ in the query syntax. Currently, the snowflake dashboards are without the ad-hoc filters, as the datasource plugin does not offer the the support. We can revisit it later if we decide to work with Grafana in the long-term. In the deployment instruction, we suggest users deploy Grafana with docker, so they do not need to install Grafana locally, and it makes the custom plugins installation simple. This PR should be merged after antrea-io#112 and antrea-io#118. The documentation shall also be merged into the README.md introduced in antrea-io#112 Signed-off-by: heanlan <hanlan@vmware.com>
heanlan
added a commit
that referenced
this pull request
Oct 11, 2022
This PR adds 4 Grafana dashboards with snowflake as the datasource: Home Dashboard, Flow Records Dashboard, Pod-to-Pod Flows Dashboard, and Network-Policy Flows Dashboard. These dashboards are basically the same with ClickHouse dashboards in their contents, differ in the query syntax. Currently, the snowflake dashboards are without the ad-hoc filters, as the datasource plugin does not offer the the support. We can revisit it later if we decide to work with Grafana in the long-term. In the deployment instruction, we suggest users deploy Grafana with docker, so they do not need to install Grafana locally, and it makes the custom plugins installation simple. This PR should be merged after #112 and #118. The documentation shall also be merged into the README.md introduced in #112 Signed-off-by: heanlan <hanlan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following two things:
When testing with snowflake datasource plugin, we found it will
automatically convert all fields name to upper case, which will
lead to string matching failure in our sankey-panel plugin and
chord-panel plugin, as we are doing case sensitive string matching.
As a work around, we do the following change to both sankey and
chord plugins: when search for fields with names in data frame,
do case insenstive string matching.
When testing with snowflake datasource plugin, we found for a field
with type String, when the value is Null, it will not convert a
Null to ''. So we change our chord panel plugin to also check for
Null value, to be compatible with different datasources.
Signed-off-by: heanlan hanlan@vmware.com